From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, xen-devel@lists.xen.org
Cc: justing@spectralogic.com, david.vrabel@citrix.com
Subject: Re: [PATCH] xen: blkif.h: document linux xen-block multi-page ring implementation
Date: Fri, 15 May 2015 11:26:45 +0200 [thread overview]
Message-ID: <5555BBD5.3000703@citrix.com> (raw)
In-Reply-To: <1431428329-6497-1-git-send-email-bob.liu@oracle.com>
El 12/05/15 a les 12.58, Bob Liu ha escrit:
> After commit 1b1586eeeb8c ("xenbus_client: Extend interface to
> support multi-page ring"), Linux xenbus driver can support multi-page ring.
>
> Based on this interface, we got some impressive improvements by using multi-page
> ring in xen-block driver. If using 64 pages as the ring, the IOPS increased
> about 15 times for the throughput testing.
>
> The Linux implementation reuses two 'DEPRECATED' nodes('max-ring-pages' and
> 'num-ring-pages), so that nothing would be broken.
> Also removed the power of 2 limit and updated the default/max value accordingly.
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
This looks fine IMHO, the only caveat I see is that you are revamping an
old feature so we need to be careful that the implementation that's
merged on Linux is compatible with the previous implementation.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Roger.
next prev parent reply other threads:[~2015-05-15 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 10:58 [PATCH] xen: blkif.h: document linux xen-block multi-page ring implementation Bob Liu
2015-05-15 9:26 ` Roger Pau Monné [this message]
2015-05-15 9:51 ` David Vrabel
2015-05-15 10:39 ` Bob Liu
2015-05-15 10:45 ` David Vrabel
2015-05-15 15:22 ` Konrad Rzeszutek Wilk
2015-05-15 15:30 ` Paul Durrant
2015-05-15 15:38 ` Jan Beulich
2015-05-15 15:54 ` Konrad Rzeszutek Wilk
2015-05-15 16:02 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5555BBD5.3000703@citrix.com \
--to=roger.pau@citrix.com \
--cc=bob.liu@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=justing@spectralogic.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.