* [review-request] michaelw/new-buildbutton-fix-7739
@ 2015-05-14 16:22 Michael Wood
2015-05-15 9:32 ` Barros Pena, Belen
0 siblings, 1 reply; 6+ messages in thread
From: Michael Wood @ 2015-05-14 16:22 UTC (permalink / raw)
To: toaster@yoctoproject.org
commit cc5ee87f905bbbaa2baf783068da23ef0f68686d
Author: Michael Wood <michael.g.wood@intel.com>
Date: Thu May 14 17:17:51 2015 +0100
bitbake: toaster: Fix build button current project race
Make sure the current project value is set before we check to see
if the
project is buildable.
[YOCTO #7739]
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [review-request] michaelw/new-buildbutton-fix-7739 2015-05-14 16:22 [review-request] michaelw/new-buildbutton-fix-7739 Michael Wood @ 2015-05-15 9:32 ` Barros Pena, Belen 2015-05-15 10:02 ` Michael Wood 0 siblings, 1 reply; 6+ messages in thread From: Barros Pena, Belen @ 2015-05-15 9:32 UTC (permalink / raw) To: Wood, Michael G; +Cc: toaster@yoctoproject.org On 14/05/2015 17:22, "Michael Wood" <michael.g.wood@intel.com> wrote: >commit cc5ee87f905bbbaa2baf783068da23ef0f68686d >Author: Michael Wood <michael.g.wood@intel.com> >Date: Thu May 14 17:17:51 2015 +0100 > > bitbake: toaster: Fix build button current project race > > Make sure the current project value is set before we check to see >if the > project is buildable. > > [YOCTO #7739] Builds start and the dialog no longer shows both the selected project name and the select project form. But the autocomplete suggestions for the project name don't work, so I can't change the selected project. Cheers, Belén > > Signed-off-by: Michael Wood <michael.g.wood@intel.com> > >-- >_______________________________________________ >toaster mailing list >toaster@yoctoproject.org >https://lists.yoctoproject.org/listinfo/toaster ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] michaelw/new-buildbutton-fix-7739 2015-05-15 9:32 ` Barros Pena, Belen @ 2015-05-15 10:02 ` Michael Wood 2015-05-15 10:03 ` Barros Pena, Belen 0 siblings, 1 reply; 6+ messages in thread From: Michael Wood @ 2015-05-15 10:02 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org On 15/05/15 10:32, Barros Pena, Belen wrote: > > On 14/05/2015 17:22, "Michael Wood" <michael.g.wood@intel.com> wrote: > >> commit cc5ee87f905bbbaa2baf783068da23ef0f68686d >> Author: Michael Wood <michael.g.wood@intel.com> >> Date: Thu May 14 17:17:51 2015 +0100 >> >> bitbake: toaster: Fix build button current project race >> >> Make sure the current project value is set before we check to see >> if the >> project is buildable. >> >> [YOCTO #7739] > Builds start and the dialog no longer shows both the selected project name > and the select project form. But the autocomplete suggestions for the > project name don't work, so I can't change the selected project. For the typeaheads in to work in toaster properly you need the patch Alex sent in adamian/20150507_toasterui_fixes fff64e507f01b712da713eb92caa0295c0548171 It's not yet merged so I'll push it to this branch for your convenience. Michael ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] michaelw/new-buildbutton-fix-7739 2015-05-15 10:02 ` Michael Wood @ 2015-05-15 10:03 ` Barros Pena, Belen 2015-05-15 10:44 ` Barros Pena, Belen 0 siblings, 1 reply; 6+ messages in thread From: Barros Pena, Belen @ 2015-05-15 10:03 UTC (permalink / raw) To: Wood, Michael G; +Cc: toaster@yoctoproject.org On 15/05/2015 11:02, "Michael Wood" <michael.g.wood@intel.com> wrote: >On 15/05/15 10:32, Barros Pena, Belen wrote: >> >> On 14/05/2015 17:22, "Michael Wood" <michael.g.wood@intel.com> wrote: >> >>> commit cc5ee87f905bbbaa2baf783068da23ef0f68686d >>> Author: Michael Wood <michael.g.wood@intel.com> >>> Date: Thu May 14 17:17:51 2015 +0100 >>> >>> bitbake: toaster: Fix build button current project race >>> >>> Make sure the current project value is set before we check to see >>> if the >>> project is buildable. >>> >>> [YOCTO #7739] >> Builds start and the dialog no longer shows both the selected project >>name >> and the select project form. But the autocomplete suggestions for the >> project name don't work, so I can't change the selected project. > >For the typeaheads in to work in toaster properly you need the patch >Alex sent in > >adamian/20150507_toasterui_fixes > >fff64e507f01b712da713eb92caa0295c0548171 > >It's not yet merged so I'll push it to this branch for your convenience. No need, I can cherry pick it. Thanks! Belén > > >Michael ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] michaelw/new-buildbutton-fix-7739 2015-05-15 10:03 ` Barros Pena, Belen @ 2015-05-15 10:44 ` Barros Pena, Belen 2015-05-21 9:37 ` Damian, Alexandru 0 siblings, 1 reply; 6+ messages in thread From: Barros Pena, Belen @ 2015-05-15 10:44 UTC (permalink / raw) To: Wood, Michael G; +Cc: toaster@yoctoproject.org On 15/05/2015 11:03, "Barros Pena, Belen" <belen.barros.pena@intel.com> wrote: > > >On 15/05/2015 11:02, "Michael Wood" <michael.g.wood@intel.com> wrote: > >>On 15/05/15 10:32, Barros Pena, Belen wrote: >>> >>> On 14/05/2015 17:22, "Michael Wood" <michael.g.wood@intel.com> wrote: >>> >>>> commit cc5ee87f905bbbaa2baf783068da23ef0f68686d >>>> Author: Michael Wood <michael.g.wood@intel.com> >>>> Date: Thu May 14 17:17:51 2015 +0100 >>>> >>>> bitbake: toaster: Fix build button current project race >>>> >>>> Make sure the current project value is set before we check to see >>>> if the >>>> project is buildable. >>>> >>>> [YOCTO #7739] >>> Builds start and the dialog no longer shows both the selected project >>>name >>> and the select project form. But the autocomplete suggestions for the >>> project name don't work, so I can't change the selected project. >> >>For the typeaheads in to work in toaster properly you need the patch >>Alex sent in >> >>adamian/20150507_toasterui_fixes >> >>fff64e507f01b712da713eb92caa0295c0548171 >> >>It's not yet merged so I'll push it to this branch for your convenience. > >No need, I can cherry pick it. Thanks! This seems good to go. Thanks! Belén > >Belén > >> >> >>Michael > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] michaelw/new-buildbutton-fix-7739 2015-05-15 10:44 ` Barros Pena, Belen @ 2015-05-21 9:37 ` Damian, Alexandru 0 siblings, 0 replies; 6+ messages in thread From: Damian, Alexandru @ 2015-05-21 9:37 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 1761 bytes --] Taken for submission, Thank you, Alex On Fri, May 15, 2015 at 11:44 AM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > > > On 15/05/2015 11:03, "Barros Pena, Belen" <belen.barros.pena@intel.com> > wrote: > > > > > > >On 15/05/2015 11:02, "Michael Wood" <michael.g.wood@intel.com> wrote: > > > >>On 15/05/15 10:32, Barros Pena, Belen wrote: > >>> > >>> On 14/05/2015 17:22, "Michael Wood" <michael.g.wood@intel.com> wrote: > >>> > >>>> commit cc5ee87f905bbbaa2baf783068da23ef0f68686d > >>>> Author: Michael Wood <michael.g.wood@intel.com> > >>>> Date: Thu May 14 17:17:51 2015 +0100 > >>>> > >>>> bitbake: toaster: Fix build button current project race > >>>> > >>>> Make sure the current project value is set before we check to see > >>>> if the > >>>> project is buildable. > >>>> > >>>> [YOCTO #7739] > >>> Builds start and the dialog no longer shows both the selected project > >>>name > >>> and the select project form. But the autocomplete suggestions for the > >>> project name don't work, so I can't change the selected project. > >> > >>For the typeaheads in to work in toaster properly you need the patch > >>Alex sent in > >> > >>adamian/20150507_toasterui_fixes > >> > >>fff64e507f01b712da713eb92caa0295c0548171 > >> > >>It's not yet merged so I'll push it to this branch for your convenience. > > > >No need, I can cherry pick it. Thanks! > > This seems good to go. > > Thanks! > > Belén > > > > >Belén > > > >> > >> > >>Michael > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 3267 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-21 9:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-14 16:22 [review-request] michaelw/new-buildbutton-fix-7739 Michael Wood 2015-05-15 9:32 ` Barros Pena, Belen 2015-05-15 10:02 ` Michael Wood 2015-05-15 10:03 ` Barros Pena, Belen 2015-05-15 10:44 ` Barros Pena, Belen 2015-05-21 9:37 ` Damian, Alexandru
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.