From: Tobias Klausmann <tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [Mesa-dev] [PATCH 00/12] Tessellation support for nvc0
Date: Sun, 17 May 2015 16:15:37 +0200 [thread overview]
Message-ID: <5558A289.8090503@mni.thm.de> (raw)
In-Reply-To: <1431839235-10256-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
as far as i can evaluate this without deeper insight into tess, this
patchseries looks good to me!
Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
On 17.05.2015 07:07, Ilia Mirkin wrote:
> This is enough to enable tessellation support on nvc0. It seems to
> work a lot better on my GF108 than GK208. I suspect that there's some
> sort of scheduling shenanigans that need to be adjusted for
> kepler+. Or perhaps some shader header things.
>
> Even with the GF108, I still get occasional blue triangles in Heaven,
> but I get a *ton* of them on the GK208 -- seemingly the same issue,
> but it's much worse on there.
>
> Also there's about a 100% chance that gl_PrimitiveID doesn't work.
>
> In any case, I plan on pushing this semi-soon unless there are any
> loud objections. I don't think it's going to do too much good sitting
> in my tree, or too much evil sitting upstream while core + st/mesa are
> worked out.
>
> Ilia Mirkin (12):
> nvc0: preliminary tess support
> nvc0: add support for setting patch vertices at draw time
> nvc0: add handling for set_tess_state callback
> nvc0: TESSCOORD comes in as a sysval, not an input
> nvc0/ir: mark varyings as per-patch based on semantic name
> nv50/ir: populate info structure based on new tess properties
> nv50/ir: set perPatch flag on load/stores to per-patch varyings
> nv50/ir: add support for reading outputs in tess control shaders
> nvc0/ir: patch vertex count is stored in the upper bits
> nvc0/ir: handle loads from outputs in control shaders
> nvc0/ir: allow tess eval output loads to be CSE'd
> nv50/ir: cleanup private enums that have graduated to gallium
>
> src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 4 +-
> .../drivers/nouveau/codegen/nv50_ir_driver.h | 12 ----
> .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 56 +++++++++++++++--
> .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 7 +++
> .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +
> src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 8 ++-
> src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 56 +++++++----------
> src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 7 +--
> src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 1 +
> .../drivers/nouveau/nvc0/nvc0_shader_state.c | 3 -
> src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 71 ++++++++++++++++++++++
> .../drivers/nouveau/nvc0/nvc0_state_validate.c | 11 ++++
> src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 34 +++++------
> src/gallium/drivers/nouveau/nvc0/nvc0_vbo.c | 9 ++-
> .../drivers/nouveau/nvc0/nvc0_vbo_translate.c | 3 +-
> 15 files changed, 200 insertions(+), 84 deletions(-)
>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2015-05-17 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 5:07 [PATCH 00/12] Tessellation support for nvc0 Ilia Mirkin
[not found] ` <1431839235-10256-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2015-05-17 5:07 ` [PATCH 01/12] nvc0: preliminary tess support Ilia Mirkin
2015-05-17 5:07 ` [PATCH 02/12] nvc0: add support for setting patch vertices at draw time Ilia Mirkin
2015-05-17 5:18 ` Ilia Mirkin
2015-05-17 5:07 ` [PATCH 03/12] nvc0: add handling for set_tess_state callback Ilia Mirkin
2015-05-17 5:07 ` [PATCH 05/12] nvc0/ir: mark varyings as per-patch based on semantic name Ilia Mirkin
2015-05-17 5:07 ` [PATCH 08/12] nv50/ir: add support for reading outputs in tess control shaders Ilia Mirkin
2015-05-17 5:07 ` [PATCH 09/12] nvc0/ir: patch vertex count is stored in the upper bits Ilia Mirkin
2015-05-17 5:07 ` [PATCH 10/12] nvc0/ir: handle loads from outputs in control shaders Ilia Mirkin
2015-05-17 5:07 ` [PATCH 11/12] nvc0/ir: allow tess eval output loads to be CSE'd Ilia Mirkin
2015-05-17 5:07 ` [PATCH 12/12] nv50/ir: cleanup private enums that have graduated to gallium Ilia Mirkin
2015-05-17 14:15 ` Tobias Klausmann [this message]
2015-05-17 5:07 ` [PATCH 04/12] nvc0: TESSCOORD comes in as a sysval, not an input Ilia Mirkin
2015-05-17 5:07 ` [PATCH 06/12] nv50/ir: populate info structure based on new tess properties Ilia Mirkin
2015-05-17 5:07 ` [PATCH 07/12] nv50/ir: set perPatch flag on load/stores to per-patch varyings Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5558A289.8090503@mni.thm.de \
--to=tobias.johannes.klausmann-aqjdnwhu20eelga04laivw@public.gmane.org \
--cc=imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.