[Buildroot] [git commit] package/enlightenment: disable ptrace with xtensa and uClibc-ng

[Buildroot] [git commit] package/enlightenment: disable ptrace with xtensa and uClibc-ng

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=cce148558119047254981aab686deff16dbba1eb
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

uCLibc-ng needs to backport the uClibc commit
de6561f6669308e5d2297589b39a217d4c14df1c to add
PT_GETSIGINFO definition.

This commit is already merged in uClibc-snapshot used by
Buildroot's toolchains for xtensa.

For now, disable ptrace with xtensa uClibc-ng toolchains.

Thanks to Gergely Imreh for the initial investigation and
patch:
http://patchwork.ozlabs.org/patch/470073/

Fixes:
http://autobuild.buildroot.net/results/77b/77b82e5b437d0778b3f6a3813f2c0a5c39b52db9

Reported-by: Gergely Imreh <imrehg@gmail.com>
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/enlightenment/enlightenment.mk |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
index ddebe06..ac15642 100644
--- a/package/enlightenment/enlightenment.mk
+++ b/package/enlightenment/enlightenment.mk
@@ -34,6 +34,11 @@ ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_powerpc)$(BR2_sparc),yy)
 ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
 endif
 
+# uClibc-ng has an old incomplete sys/ptrace.h for xtensa
+ifeq ($(BR2_UCLIBC_VERSION_NG)$(BR2_xtensa),yy)
+ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
+endif
+
 # alsa backend needs mixer support
 ifeq ($(BR2_PACKAGE_ALSA_LIB)$(BR2_PACKAGE_ALSA_LIB_MIXER),yy)
 ENLIGHTENMENT_DEPENDENCIES += alsa-lib

[Buildroot] [git commit] package/enlightenment: disable ptrace with xtensa and uClibc-ng

[Gergely Imreh]

On 18 May 2015 at 03:02, Peter Korsgaard <peter@korsgaard.com> wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=cce148558119047254981aab686deff16dbba1eb
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> uCLibc-ng needs to backport the uClibc commit
> de6561f6669308e5d2297589b39a217d4c14df1c to add
> PT_GETSIGINFO definition.
>
> This commit is already merged in uClibc-snapshot used by
> Buildroot's toolchains for xtensa.
>
> For now, disable ptrace with xtensa uClibc-ng toolchains.
>
> Thanks to Gergely Imreh for the initial investigation and
> patch:
> http://patchwork.ozlabs.org/patch/470073/
>

Awesome, thanks! As a procedural question (since this is the first
time for me like this), should I mark that linked patch in patchworks
as Superseeded and archived? I'm sure someone's doing housecleaning
there every now and than, but the less time they have to spend
reviewing things the better.

Cheers!

> Fixes:
> http://autobuild.buildroot.net/results/77b/77b82e5b437d0778b3f6a3813f2c0a5c39b52db9
>
> Reported-by: Gergely Imreh <imrehg@gmail.com>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/enlightenment/enlightenment.mk |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
> index ddebe06..ac15642 100644
> --- a/package/enlightenment/enlightenment.mk
> +++ b/package/enlightenment/enlightenment.mk
> @@ -34,6 +34,11 @@ ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_powerpc)$(BR2_sparc),yy)
>  ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
>  endif
>
> +# uClibc-ng has an old incomplete sys/ptrace.h for xtensa
> +ifeq ($(BR2_UCLIBC_VERSION_NG)$(BR2_xtensa),yy)
> +ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
> +endif
> +
>  # alsa backend needs mixer support
>  ifeq ($(BR2_PACKAGE_ALSA_LIB)$(BR2_PACKAGE_ALSA_LIB_MIXER),yy)
>  ENLIGHTENMENT_DEPENDENCIES += alsa-lib
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [git commit] package/enlightenment: disable ptrace with xtensa and uClibc-ng

[Peter Korsgaard]

>>>>> "Gergely" == Gergely Imreh <imrehg@gmail.com> writes:

Hi,

>> For now, disable ptrace with xtensa uClibc-ng toolchains.
 >> 
 >> Thanks to Gergely Imreh for the initial investigation and
 >> patch:
 >> http://patchwork.ozlabs.org/patch/470073/
 >> 

 > Awesome, thanks! As a procedural question (since this is the first
 > time for me like this), should I mark that linked patch in patchworks
 > as Superseeded and archived? I'm sure someone's doing housecleaning
 > there every now and than, but the less time they have to spend
 > reviewing things the better.

Yes, that's normally the way to go. I've gone ahead and marked the patch
as superseeded.

Thank you both.

-- 
Venlig hilsen,
Peter Korsgaard 

[Buildroot] [git commit] package/enlightenment: disable ptrace with xtensa and uClibc-ng

[Romain Naour]

Hi Gergely,

Le 18/05/2015 03:45, Gergely Imreh a ?crit :
> On 18 May 2015 at 03:02, Peter Korsgaard <peter@korsgaard.com> wrote:
>> commit: http://git.buildroot.net/buildroot/commit/?id=cce148558119047254981aab686deff16dbba1eb
>> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>
>> uCLibc-ng needs to backport the uClibc commit
>> de6561f6669308e5d2297589b39a217d4c14df1c to add
>> PT_GETSIGINFO definition.
>>
>> This commit is already merged in uClibc-snapshot used by
>> Buildroot's toolchains for xtensa.
>>
>> For now, disable ptrace with xtensa uClibc-ng toolchains.
>>
>> Thanks to Gergely Imreh for the initial investigation and
>> patch:
>> http://patchwork.ozlabs.org/patch/470073/
>>
> 
> Awesome, thanks! As a procedural question (since this is the first
> time for me like this), should I mark that linked patch in patchworks
> as Superseeded and archived? I'm sure someone's doing housecleaning
> there every now and than, but the less time they have to spend
> reviewing things the better.

Yes your patch is superseded for the xtensa part but not for PowerPC.
You can send another patch to allow ptrace with uClibc-ng an uClibc for PowerPC.

Best regards,
Romain
> 
> Cheers!
> 
>> Fixes:
>> http://autobuild.buildroot.net/results/77b/77b82e5b437d0778b3f6a3813f2c0a5c39b52db9
>>
>> Reported-by: Gergely Imreh <imrehg@gmail.com>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---