Re: [PATCH] spi: omap2-mcspi: Add calls for pinctrl state select

[Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 13.05.2015 20:15, Mark Brown wrote:
> On Wed, May 13, 2015 at 02:15:16PM +0200, pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> 
>> This adds calls to pinctrl subsystem in order to switch pin states
>> on suspend/resume if you provide a "sleep" state in DT.
> 
>> If no "sleep" state is provided in DT, these calls turn
>> to NOPs, so we don't need error checking here.
> 
> We should still be checking if we succesfully changed the state when
> there is a state provided shouldn't we?

I agree, but if I git grep for such calls, nobody seems to check the
return values of these functions. Shall I add a check and print a
message if the call fails?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html