All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: omap2-mcspi: Add calls for pinctrl state select
Date: Tue, 09 Jun 2015 13:16:33 +0200	[thread overview]
Message-ID: <5576CB11.7010905@gmail.com> (raw)
In-Reply-To: <20150519121225.GM2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

Hey Mark,

On 19.05.2015 14:12, Mark Brown wrote:
> On Mon, May 18, 2015 at 02:02:04PM +0200, Pascal Huerst wrote:
>> On 13.05.2015 20:15, Mark Brown wrote:
> 
>>> We should still be checking if we succesfully changed the state when
>>> there is a state provided shouldn't we?
> 
>> I agree, but if I git grep for such calls, nobody seems to check the
>> return values of these functions. Shall I add a check and print a
>> message if the call fails?
> 
> Yes, please.

Sorry for the late reply.

There is already a message printed on failure in the subsystem. See:
http://lxr.free-electrons.com/source/drivers/pinctrl/core.c#L1250

So I don't see the need for another message, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-06-09 11:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 12:15 [PATCH] spi: omap2-mcspi: Add calls for pinctrl state select pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w
     [not found] ` <1431519316-30989-1-git-send-email-pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-13 18:15   ` Mark Brown
     [not found]     ` <20150513181536.GI2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-18 12:02       ` Pascal Huerst
     [not found]         ` <5559D4BC.6010606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-19 12:12           ` Mark Brown
     [not found]             ` <20150519121225.GM2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-06-09 11:16               ` Pascal Huerst [this message]
     [not found]                 ` <5576CB11.7010905-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-14 16:10                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5576CB11.7010905@gmail.com \
    --to=pascal.huerst-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.