From: Lars-Peter Clausen <lars@metafoo.de>
To: "Urs Fässler" <urs.fassler@bytesatwork.ch>,
jic23@kernel.org, angelo.compagnucci@gmail.com
Cc: iivanov@mm-sol.com, ezequiel.garcia@imgtec.com,
jacob.jun.pan@linux.intel.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc128s052: add support for adc122s021
Date: Mon, 18 May 2015 14:19:17 +0200 [thread overview]
Message-ID: <5559D8C5.9060407@metafoo.de> (raw)
In-Reply-To: <1431950676-22379-2-git-send-email-urs.fassler@bytesatwork.ch>
> --- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -1,7 +1,7 @@
> -* Texas Instruments' ADC128S052 ADC chip
> +* Texas Instruments' ADC128S052 and ADC122S021 ADC chip
>
> Required properties:
> - - compatible: Should be "ti,adc128s052"
> + - compatible: Should be "adc128s052" or "adc122s021"
Why are you removing the vendor prefix? The compatible string is not valid
without a vendor prefix.
> - reg: spi chip select number for the device
> - vref-supply: The regulator supply for ADC reference voltage
>
> @@ -11,7 +11,7 @@ Recommended properties:
>
> Example:
> adc@0 {
> - compatible = "ti,adc128s052";
> + compatible = "adc128s052";
Indention.
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: "Urs Fässler"
<urs.fassler-31H8OHFNM6fpWzRi28bHsw@public.gmane.org>,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
angelo.compagnucci-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org,
ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org,
jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iio: adc128s052: add support for adc122s021
Date: Mon, 18 May 2015 14:19:17 +0200 [thread overview]
Message-ID: <5559D8C5.9060407@metafoo.de> (raw)
In-Reply-To: <1431950676-22379-2-git-send-email-urs.fassler-31H8OHFNM6fpWzRi28bHsw@public.gmane.org>
> --- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -1,7 +1,7 @@
> -* Texas Instruments' ADC128S052 ADC chip
> +* Texas Instruments' ADC128S052 and ADC122S021 ADC chip
>
> Required properties:
> - - compatible: Should be "ti,adc128s052"
> + - compatible: Should be "adc128s052" or "adc122s021"
Why are you removing the vendor prefix? The compatible string is not valid
without a vendor prefix.
> - reg: spi chip select number for the device
> - vref-supply: The regulator supply for ADC reference voltage
>
> @@ -11,7 +11,7 @@ Recommended properties:
>
> Example:
> adc@0 {
> - compatible = "ti,adc128s052";
> + compatible = "adc128s052";
Indention.
next prev parent reply other threads:[~2015-05-18 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 12:04 [PATCH] iio: adc128s052: add support for adc122s021 Urs Fässler
2015-05-18 12:04 ` Urs Fässler
2015-05-18 12:04 ` Urs Fässler
2015-05-18 12:19 ` Lars-Peter Clausen [this message]
2015-05-18 12:19 ` Lars-Peter Clausen
2015-05-18 12:40 ` Peter Meerwald
-- strict thread matches above, loose matches on Subject: below --
2015-05-18 13:22 [PATCH v2] " Urs Fässler
2015-05-18 13:22 ` [PATCH] " Urs Fässler
2015-05-18 13:22 ` Urs Fässler
2015-05-23 11:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5559D8C5.9060407@metafoo.de \
--to=lars@metafoo.de \
--cc=angelo.compagnucci@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=iivanov@mm-sol.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=urs.fassler@bytesatwork.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.