Re: [PATCH v5 3/3] ARM: berlin: add an ADC node for the BG2Q

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 18.05.2015 11:19, Antoine Tenart wrote:
> This patch adds the ADC node for the Berlin BG2Q, using the newly added
> Berlin IIO ADC driver.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>   arch/arm/boot/dts/berlin2q.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 187d056f7ad2..97c7e19e3ec6 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -565,6 +565,13 @@
>   						function = "twsi3";
>   					};
>   				};
> +
> +				adc: adc {
> +					compatible = "marvell,berlin2-adc";
> +					interrupt-parent = <&sic>;

Antoine,

a side note on the interrupt-parent property above:

The parent simple-bus node already contains that property. If you
remove the property here, don't the interrupt routines go up the
hierarchy until they find an interrupt-parent set?

So, is it safe to get rid of the extra interrupt-parent property on
the adc node?

Sebastian

> +					interrupts = <12>, <14>;
> +					interrupt-names = "adc", "tsen";
> +				};
>   			};
>
>   			sic: interrupt-controller@e000 {
>