From: Jiri Slaby <jslaby@suse.cz>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Peter Hurley <peter@hurleysoftware.com>,
John Crispin <blogic@openwrt.org>,
Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joachim Eastwood <manabian@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver
Date: Tue, 19 May 2015 10:57:59 +0200 [thread overview]
Message-ID: <555AFB17.1050703@suse.cz> (raw)
In-Reply-To: <CAK7LNARrjkCcMsVJwe5hdB71QsEQAf51sNf4xYVMkNazdbdxKA@mail.gmail.com>
On 05/19/2015, 10:54 AM, Masahiro Yamada wrote:
>>> +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */
>>> +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */
>>> +#define UNIPHIER_UART_LCR_SHIFT 8
>>> +#define UNIPHIER_UART_DLR 9 /* Divisor Latch Register */
>>
>> Nit pick: Please fix identation. After "define" just put one blank.
>> I personally prefer that the define values are aligned by tabs, but
>> that's up tu you.
>>
>
> I intentionally use deeper indentation for *_SHIFT
> because I want to clearly show UNIPHIER_UART_LCR_SHIFT
> belongs to UNIPHIER_UART_LCR_MCR register.
>
> I also want to describe them within 80 columns including comments,
> so I cannot insert extra TABs to align the values.
Hi, what about one space between # and define which is used sometimes?
--
js
suse labs
WARNING: multiple messages have this Message-ID (diff)
From: jslaby@suse.cz (Jiri Slaby)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver
Date: Tue, 19 May 2015 10:57:59 +0200 [thread overview]
Message-ID: <555AFB17.1050703@suse.cz> (raw)
In-Reply-To: <CAK7LNARrjkCcMsVJwe5hdB71QsEQAf51sNf4xYVMkNazdbdxKA@mail.gmail.com>
On 05/19/2015, 10:54 AM, Masahiro Yamada wrote:
>>> +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */
>>> +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */
>>> +#define UNIPHIER_UART_LCR_SHIFT 8
>>> +#define UNIPHIER_UART_DLR 9 /* Divisor Latch Register */
>>
>> Nit pick: Please fix identation. After "define" just put one blank.
>> I personally prefer that the define values are aligned by tabs, but
>> that's up tu you.
>>
>
> I intentionally use deeper indentation for *_SHIFT
> because I want to clearly show UNIPHIER_UART_LCR_SHIFT
> belongs to UNIPHIER_UART_LCR_MCR register.
>
> I also want to describe them within 80 columns including comments,
> so I cannot insert extra TABs to align the values.
Hi, what about one space between # and define which is used sometimes?
--
js
suse labs
next prev parent reply other threads:[~2015-05-19 8:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 1:11 [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver Masahiro Yamada
2015-05-19 1:11 ` Masahiro Yamada
2015-05-19 8:22 ` Matthias Brugger
2015-05-19 8:22 ` Matthias Brugger
2015-05-19 8:54 ` Masahiro Yamada
2015-05-19 8:54 ` Masahiro Yamada
2015-05-19 8:57 ` Jiri Slaby [this message]
2015-05-19 8:57 ` Jiri Slaby
2015-05-19 9:10 ` Masahiro Yamada
2015-05-19 9:10 ` Masahiro Yamada
2015-05-19 9:48 ` One Thousand Gnomes
2015-05-19 11:18 ` Masahiro Yamada
2015-05-19 11:18 ` Masahiro Yamada
2015-05-19 11:31 ` Matthias Brugger
2015-05-19 11:31 ` Matthias Brugger
2015-05-19 10:13 ` Matthias Brugger
2015-05-19 10:13 ` Matthias Brugger
2015-05-20 12:56 ` Andy Shevchenko
2015-05-20 12:56 ` Andy Shevchenko
2015-05-23 12:55 ` Masahiro Yamada
2015-05-23 12:55 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555AFB17.1050703@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=blogic@openwrt.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=peter@hurleysoftware.com \
--cc=ricardo.ribalda@gmail.com \
--cc=tony@atomide.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.