Re: [review-request] michaelw/porting-layerdetails-tables

[Michael Wood <michael.g.wood@intel.com>]

On 19/05/15 12:34, Barros Pena, Belen wrote:
> Looking pretty good. Only one comment: these tables should only show
> search and show rows menu if they have more than 10 entries.

Is that feature wanted for both kinds of the table?

And that's if a search or filter is not currently applied right?


> Thanks!
>
> Belén
>
> On 18/05/2015 20:33, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> Squeezed in a few clean ups into this as well.
>>
>> commit 347aa8fd766f5fa0bd720ba9528dc006a59f7a47
>> Author: Michael Wood <michael.g.wood@intel.com>
>> Date:   Mon May 18 20:08:28 2015 +0100
>>
>>      bitbake: toaster: Port layerdetails to ToasterTables
>>
>>      This ports the layerdetails page to using ToasterTables
>>      Also some whitespace and strict clean ups in the existing
>> layerdetails
>>      js and html template.
>>
>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>
>> commit ebf6b73f4dcb1eeb6a77a3a921dd6dc2693f64f1
>> Author: Michael Wood <michael.g.wood@intel.com>
>> Date:   Mon May 18 20:01:44 2015 +0100
>>
>>      bitbake: toaster: Add a simplified ToasterTable template
>>
>>      This is like the normal ToasterTable template but with a number of
>>      features removed such as edit columns and has a lower profile
>> compared
>>      to the "main" tables.
>>
>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>
>>
>>
>> -- 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster