Re: [review-request] michaelw/porting-layerdetails-tables

[Michael Wood <michael.g.wood@intel.com>]

v2 pushed

Note I've fixed a caching issue I spotted

Full list of commits for review:

commit 096423c4375b6d628b4eb408bbdab6411bd16715
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Tue May 19 16:10:19 2015 +0100

     bitbake: toaster: Add an invalidate cache method on data update signal

     Instead of relying on the cache expiring over an amount of time we can
     listen to the changed notification on the models to invalidate the
     cache. Also fixes overlapping cache names.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

commit 17d07ac77e411de5c8dd4e6b216330d766bde34a
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Mon May 18 20:08:28 2015 +0100

     bitbake: toaster: Port layerdetails to ToasterTables

     This ports the layerdetails page to using ToasterTables
     Also some whitespace and strict clean ups in the existing layerdetails
     js and html template.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

commit 34a6159e14da621e356ccd6ec56059ef6a685583
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Mon May 18 20:01:44 2015 +0100

     bitbake: toaster: Add a simplified ToasterTable template

     This is like the normal ToasterTable template but with a number of
     features removed such as edit columns and has a lower profile compared
     to the "main" tables.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

commit 48931980173e4f69ec24c246b6b8b6a9ee9b0ed8
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Mon May 18 13:44:53 2015 +0100

     bitbake: toaster: Fix toastertable header

     Fixes regression introduced by 'tables updates for HTML5 compliance'

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>





On 19/05/15 13:49, Barros Pena, Belen wrote:
>
> On 19/05/2015 13:40, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> On 19/05/15 12:34, Barros Pena, Belen wrote:
>>> Looking pretty good. Only one comment: these tables should only show
>>> search and show rows menu if they have more than 10 entries.
>> Is that feature wanted for both kinds of the table?
> No, only the ones in the 'details' pages (recipe details, package details,
> layer details kind of thing). So this is not needed in the higher level
> tables (all layers, all packages, all recipes, all tasks, all compatible
> layers, all compatible recipes, all compatible machines and so on).
> Although the higher level tables pretty much always have more than 10
> entries, so I guess if you implement the logic in both the practical
> implications are negligible. If that's easier, go for it.
>
>> And that's if a search or filter is not currently applied right?
> Yes, indeed.
>
>>
>>> Thanks!
>>>
>>> Belén
>>>
>>> On 18/05/2015 20:33, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>>
>>>> Squeezed in a few clean ups into this as well.
>>>>
>>>> commit 347aa8fd766f5fa0bd720ba9528dc006a59f7a47
>>>> Author: Michael Wood <michael.g.wood@intel.com>
>>>> Date:   Mon May 18 20:08:28 2015 +0100
>>>>
>>>>       bitbake: toaster: Port layerdetails to ToasterTables
>>>>
>>>>       This ports the layerdetails page to using ToasterTables
>>>>       Also some whitespace and strict clean ups in the existing
>>>> layerdetails
>>>>       js and html template.
>>>>
>>>>       Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>>>
>>>> commit ebf6b73f4dcb1eeb6a77a3a921dd6dc2693f64f1
>>>> Author: Michael Wood <michael.g.wood@intel.com>
>>>> Date:   Mon May 18 20:01:44 2015 +0100
>>>>
>>>>       bitbake: toaster: Add a simplified ToasterTable template
>>>>
>>>>       This is like the normal ToasterTable template but with a number of
>>>>       features removed such as edit columns and has a lower profile
>>>> compared
>>>>       to the "main" tables.
>>>>
>>>>       Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>>>
>>>>
>>>>
>>>> -- 
>>>> _______________________________________________
>>>> toaster mailing list
>>>> toaster@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/toaster