* [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list @ 2015-05-19 0:19 Fabio Estevam 2015-05-19 12:05 ` Otavio Salvador 0 siblings, 1 reply; 6+ messages in thread From: Fabio Estevam @ 2015-05-19 0:19 UTC (permalink / raw) To: otavio; +Cc: meta-freescale, Fabio Estevam From: Fabio Estevam <fabio.estevam@freescale.com> imx53qsb does not have any Wifi and Bluetooth devices on-board, so remove the firmware and features list. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- conf/machine/imx53qsb.conf | 4 ---- 1 file changed, 4 deletions(-) diff --git a/conf/machine/imx53qsb.conf b/conf/machine/imx53qsb.conf index 0e7349e..5fadd6e 100644 --- a/conf/machine/imx53qsb.conf +++ b/conf/machine/imx53qsb.conf @@ -15,7 +15,3 @@ PERF_FEATURES_ENABLE = "" KERNEL_DEVICETREE = "imx53-qsb.dtb imx53-qsrb.dtb" UBOOT_MACHINE = "mx53loco_config" - -MACHINE_FIRMWARE = "linux-firmware-ar3k \ - linux-firmware-ath6k" -MACHINE_FEATURES += " wifi bluetooth" -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list 2015-05-19 0:19 [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list Fabio Estevam @ 2015-05-19 12:05 ` Otavio Salvador 2015-05-19 13:19 ` Fabio Estevam 0 siblings, 1 reply; 6+ messages in thread From: Otavio Salvador @ 2015-05-19 12:05 UTC (permalink / raw) To: Fabio Estevam; +Cc: meta-freescale@yoctoproject.org, Fabio Estevam On Mon, May 18, 2015 at 9:19 PM, Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > imx53qsb does not have any Wifi and Bluetooth devices on-board, so remove > the firmware and features list. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> This has been added, at that time, because Freescale used the adaptor to do tests. I am not against removing this but several boards we have included list the 'capability' of using WiFi / Bluetooth, not strictly if it is at board or not. Let me know your thoughts on this. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list 2015-05-19 12:05 ` Otavio Salvador @ 2015-05-19 13:19 ` Fabio Estevam 2015-05-19 13:31 ` Daiane Angolini 0 siblings, 1 reply; 6+ messages in thread From: Fabio Estevam @ 2015-05-19 13:19 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org, Fabio Estevam Hi Otavio, On Tue, May 19, 2015 at 9:05 AM, Otavio Salvador <otavio@ossystems.com.br> wrote: > This has been added, at that time, because Freescale used the adaptor > to do tests. I am not against removing this but several boards we have > included list the 'capability' of using WiFi / Bluetooth, not strictly > if it is at board or not. > > Let me know your thoughts on this. I would prefer to pass in MACHINE_FEATURES only the features that the boards support natively. Otherwise, every board with a USB port, SDIO or PCIe port could list many possible features of devices that could be potentially attached to it. If we restrict MACHINE_FEATURES to only the devices that are built-in, then we have a more common approach to the various supported machines. Regards, Fabio Estevam ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list 2015-05-19 13:19 ` Fabio Estevam @ 2015-05-19 13:31 ` Daiane Angolini 2015-05-19 14:07 ` Nikolay Dimitrov 0 siblings, 1 reply; 6+ messages in thread From: Daiane Angolini @ 2015-05-19 13:31 UTC (permalink / raw) To: Fabio Estevam Cc: meta-freescale@yoctoproject.org, Fabio Estevam, Otavio Salvador On Tue, May 19, 2015 at 10:19 AM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Otavio, > > On Tue, May 19, 2015 at 9:05 AM, Otavio Salvador > <otavio@ossystems.com.br> wrote: > >> This has been added, at that time, because Freescale used the adaptor >> to do tests. I am not against removing this but several boards we have >> included list the 'capability' of using WiFi / Bluetooth, not strictly >> if it is at board or not. >> >> Let me know your thoughts on this. > > I would prefer to pass in MACHINE_FEATURES only the features that the > boards support natively. > > Otherwise, every board with a USB port, SDIO or PCIe port could list > many possible features of devices that could be potentially attached > to it. > > If we restrict MACHINE_FEATURES to only the devices that are built-in, > then we have a more common approach to the various supported machines. It is weird to see ~once again~ an old conversation taking place in mailing list. I remember to have discussed about this few years ago. In my opinion, we have basically 2 kinds of boards: the products and the references. And, in my opinion, the reference boards should include WIFI in MACHINE_FEATURES even if they don't have it physically in the board. I mean, if board has a PCIe, it is one of the board goals to ~have thing attached to it~, and one of the most often attached stuff is WIFI or/and Bluetooth. For products, it's straightforward that the board maintainer decides which is the best, as this is a gray area. Daiane > > Regards, > > Fabio Estevam > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list 2015-05-19 13:31 ` Daiane Angolini @ 2015-05-19 14:07 ` Nikolay Dimitrov 2015-05-19 14:17 ` Daiane Angolini 0 siblings, 1 reply; 6+ messages in thread From: Nikolay Dimitrov @ 2015-05-19 14:07 UTC (permalink / raw) To: Daiane Angolini, Fabio Estevam Cc: meta-freescale@yoctoproject.org, Fabio Estevam, Otavio Salvador Hi Daiane, On 05/19/2015 04:31 PM, Daiane Angolini wrote: > On Tue, May 19, 2015 at 10:19 AM, Fabio Estevam <festevam@gmail.com> > wrote: >> Hi Otavio, >> >> On Tue, May 19, 2015 at 9:05 AM, Otavio Salvador >> <otavio@ossystems.com.br> wrote: >> >>> This has been added, at that time, because Freescale used the >>> adaptor to do tests. I am not against removing this but several >>> boards we have included list the 'capability' of using WiFi / >>> Bluetooth, not strictly if it is at board or not. >>> >>> Let me know your thoughts on this. >> >> I would prefer to pass in MACHINE_FEATURES only the features that >> the boards support natively. >> >> Otherwise, every board with a USB port, SDIO or PCIe port could >> list many possible features of devices that could be potentially >> attached to it. >> >> If we restrict MACHINE_FEATURES to only the devices that are >> built-in, then we have a more common approach to the various >> supported machines. > > It is weird to see ~once again~ an old conversation taking place in > mailing list. > > I remember to have discussed about this few years ago. > > In my opinion, we have basically 2 kinds of boards: the products and > the references. > > And, in my opinion, the reference boards should include WIFI in > MACHINE_FEATURES even if they don't have it physically in the board. In order to support all kinds of WIFI devices, it will also require all kernel drivers for these devices to be enabled, and currently this is not the case. Another issue is that leaving/setting the WIFI feature and kernel drivers enabled implies that Freescale or the community board maintainer has tested all these devices on the reference builds, which I doubt is possible. In general, I tend to agree with Fabio that what's physically available on the board should be supported out of the box. Just kindly sharing my thoughts, please feel to disagree with me. > I mean, if board has a PCIe, it is one of the board goals to ~have > thing attached to it~, and one of the most often attached stuff is > WIFI or/and Bluetooth. > > For products, it's straightforward that the board maintainer decides > which is the best, as this is a gray area. Kind regards, Nikolay ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list 2015-05-19 14:07 ` Nikolay Dimitrov @ 2015-05-19 14:17 ` Daiane Angolini 0 siblings, 0 replies; 6+ messages in thread From: Daiane Angolini @ 2015-05-19 14:17 UTC (permalink / raw) To: Nikolay Dimitrov Cc: meta-freescale@yoctoproject.org, Fabio Estevam, Otavio Salvador On Tue, May 19, 2015 at 11:07 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > Hi Daiane, > > > On 05/19/2015 04:31 PM, Daiane Angolini wrote: >> >> On Tue, May 19, 2015 at 10:19 AM, Fabio Estevam <festevam@gmail.com> >> wrote: >>> >>> Hi Otavio, >>> >>> On Tue, May 19, 2015 at 9:05 AM, Otavio Salvador >>> <otavio@ossystems.com.br> wrote: >>> >>>> This has been added, at that time, because Freescale used the >>>> adaptor to do tests. I am not against removing this but several >>>> boards we have included list the 'capability' of using WiFi / >>>> Bluetooth, not strictly if it is at board or not. >>>> >>>> Let me know your thoughts on this. >>> >>> >>> I would prefer to pass in MACHINE_FEATURES only the features that >>> the boards support natively. >>> >>> Otherwise, every board with a USB port, SDIO or PCIe port could >>> list many possible features of devices that could be potentially >>> attached to it. >>> >>> If we restrict MACHINE_FEATURES to only the devices that are >>> built-in, then we have a more common approach to the various >>> supported machines. >> >> >> It is weird to see ~once again~ an old conversation taking place in >> mailing list. >> >> I remember to have discussed about this few years ago. >> >> In my opinion, we have basically 2 kinds of boards: the products and >> the references. >> >> And, in my opinion, the reference boards should include WIFI in >> MACHINE_FEATURES even if they don't have it physically in the board. > > > In order to support all kinds of WIFI devices, it will also require all > kernel drivers for these devices to be enabled, and currently this is > not the case. > > Another issue is that leaving/setting the WIFI feature and kernel > drivers enabled implies that Freescale or the community board maintainer > has tested all these devices on the reference builds, which I doubt is > possible. > > In general, I tend to agree with Fabio that what's physically available > on the board should be supported out of the box. > > Just kindly sharing my thoughts, please feel to disagree with me. Well, I don't have strong feelings about it. Let's decide which are the best way to document it so. This way we get it clear in the source code or documentation. Daiane > >> I mean, if board has a PCIe, it is one of the board goals to ~have >> thing attached to it~, and one of the most often attached stuff is >> WIFI or/and Bluetooth. >> >> For products, it's straightforward that the board maintainer decides >> which is the best, as this is a gray area. > > > Kind regards, > Nikolay ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-19 14:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-19 0:19 [PATCH][meta-fsl-arm] imx53qsb: Remove firmware and features list Fabio Estevam 2015-05-19 12:05 ` Otavio Salvador 2015-05-19 13:19 ` Fabio Estevam 2015-05-19 13:31 ` Daiane Angolini 2015-05-19 14:07 ` Nikolay Dimitrov 2015-05-19 14:17 ` Daiane Angolini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.