[Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood

[Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

According to Documentation/SubmittingPatches:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.

So do as recommended.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 scripts/coccinelle/misc/semicolon.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/misc/semicolon.cocci b/scripts/coccinelle/misc/semicolon.cocci
index a47eba2..6740c65 100644
--- a/scripts/coccinelle/misc/semicolon.cocci
+++ b/scripts/coccinelle/misc/semicolon.cocci
@@ -1,5 +1,5 @@
 ///
-/// Removes unneeded semicolon.
+/// Remove unneeded semicolon.
 ///
 // Confidence: Moderate
 // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
-- 
1.9.1

[Cocci] [PATCH 2/2] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Correct form is 'always requested'.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
index a24a754..b17ac8b 100644
--- a/scripts/coccinelle/misc/irqf_oneshot.cocci
+++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
@@ -1,4 +1,4 @@
-/// Make sure threaded IRQs without a primary handler are always request with
+/// Make sure threaded IRQs without a primary handler are always requested with
 /// IRQF_ONESHOT
 ///
 //
-- 
1.9.1

[Cocci] [PATCH 2/2] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar

[Julia Lawall]

On Sat, 9 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Correct form is 'always requested'.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> index a24a754..b17ac8b 100644
> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
> @@ -1,4 +1,4 @@
> -/// Make sure threaded IRQs without a primary handler are always request with
> +/// Make sure threaded IRQs without a primary handler are always requested with
>  /// IRQF_ONESHOT
>  ///
>  //
> -- 
> 1.9.1
> 
> 

[Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood

[Julia Lawall]

On Sat, 9 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> According to Documentation/SubmittingPatches:
> 
> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
> 
> So do as recommended.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  scripts/coccinelle/misc/semicolon.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/misc/semicolon.cocci b/scripts/coccinelle/misc/semicolon.cocci
> index a47eba2..6740c65 100644
> --- a/scripts/coccinelle/misc/semicolon.cocci
> +++ b/scripts/coccinelle/misc/semicolon.cocci
> @@ -1,5 +1,5 @@
>  ///
> -/// Removes unneeded semicolon.
> +/// Remove unneeded semicolon.
>  ///
>  // Confidence: Moderate
>  // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
> -- 
> 1.9.1
> 
> 

[Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood

[Michal Marek]

Dne 10.5.2015 v 00:44 Julia Lawall napsal(a):
> 
> 
> On Sat, 9 May 2015, Fabio Estevam wrote:
> 
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> According to Documentation/SubmittingPatches:
>>
>> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
>> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
>> to do frotz", as if you are giving orders to the codebase to change
>> its behaviour.
>>
>> So do as recommended.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Fabio, could you please resend me these two patches? It seems I wasn't
on CC (or I accidentally dropped them :)).

Michal