From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Alexandre Courbot
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] serial: tegra: Fix memory leak on DMA setup failure
Date: Wed, 20 May 2015 12:33:22 +0100 [thread overview]
Message-ID: <555C7102.8060207@nvidia.com> (raw)
In-Reply-To: <555C6F38.50603-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 20/05/15 12:25, Jon Hunter wrote:
>
> On 20/05/15 12:21, Jon Hunter wrote:
>> If the call to dmaengine_slave_config() fails, then the DMA buffer will
>> not be freed/unmapped. Fix this by moving the code that stores the
>> address of the buffer in the tegra_uart_port structure to before the
>> call to dmaengine_slave_config().
>
> By the way, just to be clear, I did try to fix this before [1], but
> failed :-(
To be doubly clear, this is targeted to be applied on top of the
previous patch [1] which is now in linux-next.
Jon
> [1] https://lkml.org/lkml/2015/5/5/802
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.cz>
Cc: <linux-serial@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: tegra: Fix memory leak on DMA setup failure
Date: Wed, 20 May 2015 12:33:22 +0100 [thread overview]
Message-ID: <555C7102.8060207@nvidia.com> (raw)
In-Reply-To: <555C6F38.50603@nvidia.com>
On 20/05/15 12:25, Jon Hunter wrote:
>
> On 20/05/15 12:21, Jon Hunter wrote:
>> If the call to dmaengine_slave_config() fails, then the DMA buffer will
>> not be freed/unmapped. Fix this by moving the code that stores the
>> address of the buffer in the tegra_uart_port structure to before the
>> call to dmaengine_slave_config().
>
> By the way, just to be clear, I did try to fix this before [1], but
> failed :-(
To be doubly clear, this is targeted to be applied on top of the
previous patch [1] which is now in linux-next.
Jon
> [1] https://lkml.org/lkml/2015/5/5/802
next prev parent reply other threads:[~2015-05-20 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 11:21 [PATCH] serial: tegra: Fix memory leak on DMA setup failure Jon Hunter
2015-05-20 11:21 ` Jon Hunter
2015-05-20 11:25 ` Jon Hunter
2015-05-20 11:25 ` Jon Hunter
[not found] ` <555C6F38.50603-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-05-20 11:33 ` Jon Hunter [this message]
2015-05-20 11:33 ` Jon Hunter
2015-05-21 5:27 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C7102.8060207@nvidia.com \
--to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.