From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition
Date: Wed, 20 May 2015 14:46:23 +0200 [thread overview]
Message-ID: <555C821F.7090104@atmel.com> (raw)
In-Reply-To: <20150520124154.GB3907@piout.net>
Le 20/05/2015 14:41, Alexandre Belloni a ?crit :
> On 20/05/2015 at 14:36:10 +0200, Nicolas Ferre wrote :
>> SCK1 pin is pioC 29. Comment was okay.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index 9c236c317eeb..dfdbdf43860e 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -505,7 +505,7 @@
>>
>> pinctrl_usart1_sck: usart1_sck-0 {
>> atmel,pins =
>> - <AT91_PIOC 28 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
>> + <AT91_PIOC 29 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
>
> I think you should remove the comment. As you can see, it didn't help ;)
I agree, but didn't do it in this patch because the whole file is
stuffed with these useless comments... We'd better do it in a single
patch or... leave it like this...
Bye,
>> };
>> };
>>
>> --
>> 2.1.3
>>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition
Date: Wed, 20 May 2015 14:46:23 +0200 [thread overview]
Message-ID: <555C821F.7090104@atmel.com> (raw)
In-Reply-To: <20150520124154.GB3907@piout.net>
Le 20/05/2015 14:41, Alexandre Belloni a écrit :
> On 20/05/2015 at 14:36:10 +0200, Nicolas Ferre wrote :
>> SCK1 pin is pioC 29. Comment was okay.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index 9c236c317eeb..dfdbdf43860e 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -505,7 +505,7 @@
>>
>> pinctrl_usart1_sck: usart1_sck-0 {
>> atmel,pins =
>> - <AT91_PIOC 28 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
>> + <AT91_PIOC 29 AT91_PERIPH_C AT91_PINCTRL_NONE>; /* PC29 periph C */
>
> I think you should remove the comment. As you can see, it didn't help ;)
I agree, but didn't do it in this patch because the whole file is
stuffed with these useless comments... We'd better do it in a single
patch or... leave it like this...
Bye,
>> };
>> };
>>
>> --
>> 2.1.3
>>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-05-20 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 12:36 [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition Nicolas Ferre
2015-05-20 12:36 ` Nicolas Ferre
2015-05-20 12:41 ` Alexandre Belloni
2015-05-20 12:41 ` Alexandre Belloni
2015-05-20 12:46 ` Nicolas Ferre [this message]
2015-05-20 12:46 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C821F.7090104@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.