All of lore.kernel.org
 help / color / mirror / Atom feed
From: cory.tusar@pid1solutions.com (Cory Tusar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: vf610: Extend I2C support to all available busses.
Date: Wed, 20 May 2015 09:31:41 -0400	[thread overview]
Message-ID: <555C8CBD.7000007@pid1solutions.com> (raw)
In-Reply-To: <1432089939-1086-1-git-send-email-cory.tusar@pid1solutions.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/19/2015 10:45 PM, Cory Tusar wrote:
> This commit extends the existing Vybrid I2C support to cover busses
> I2C1, I2C2, and I2C3.

And...I'm going to NAK my version of this patch - the i2c2 and i2c3
mappings should be under aips1 rather than aips0.

Also, I see that Stefan has a similar change up in the linux-toradex
tree:

http://git.toradex.com/cgit/linux-toradex.git/commit/arch/arm/boot/dts/vfxxx.dtsi?h=toradex_vf_4.0&id=7863765e0f3d2a20a0a69e49c44c1e2f96608c8f

I'll follow-up with him directly about resolving differences in our two
implementations.

- -Cory


> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..ec98b6c 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -347,6 +347,48 @@
>  				status = "disabled";
>  			};
>  
> +			i2c1: i2c at 40067000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x40067000 0x1000>;
> +				interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C1>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 0 52>,
> +					<&edma0 0 53>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
> +			i2c2: i2c at 400e6000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x400e6000 0x1000>;
> +				interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C2>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 1 36>,
> +					<&edma0 1 37>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
> +			i2c3: i2c at 400e7000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x400e7000 0x1000>;
> +				interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C3>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 1 38>,
> +					<&edma0 1 39>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
>  			clks: ccm at 4006b000 {
>  				compatible = "fsl,vf610-ccm";
>  				reg = <0x4006b000 0x1000>;
> 


- -- 
Cory T. Tusar
Principal
PID 1 Solutions, Inc.
(814) 553-8619


"There are two ways of constructing a software design.  One way is to
 make it so simple that there are obviously no deficiencies, and the
 other way is to make it so complicated that there are no obvious
 deficiencies."  --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlVcjL0ACgkQHT1tsfGwHJ9szACfVfARbngdf0C1ZjNSvzzIMwlW
eAkAn2ne/PAOKBZVH/L4FP0Qmi+GWJLu
=FpuI
-----END PGP SIGNATURE-----

WARNING: multiple messages have this Message-ID (diff)
From: Cory Tusar <cory.tusar-J6Z/VSE8EyIAspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
To: shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	stefan-XLVq0VzYD2Y@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	mirza.krak-3xdUHytR7SMQwY+2splSUA@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available busses.
Date: Wed, 20 May 2015 09:31:41 -0400	[thread overview]
Message-ID: <555C8CBD.7000007@pid1solutions.com> (raw)
In-Reply-To: <1432089939-1086-1-git-send-email-cory.tusar-J6Z/VSE8EyIAspv4Qr0y0gC/G2K4zDHf@public.gmane.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/19/2015 10:45 PM, Cory Tusar wrote:
> This commit extends the existing Vybrid I2C support to cover busses
> I2C1, I2C2, and I2C3.

And...I'm going to NAK my version of this patch - the i2c2 and i2c3
mappings should be under aips1 rather than aips0.

Also, I see that Stefan has a similar change up in the linux-toradex
tree:

http://git.toradex.com/cgit/linux-toradex.git/commit/arch/arm/boot/dts/vfxxx.dtsi?h=toradex_vf_4.0&id=7863765e0f3d2a20a0a69e49c44c1e2f96608c8f

I'll follow-up with him directly about resolving differences in our two
implementations.

- -Cory


> Signed-off-by: Cory Tusar <cory.tusar-J6Z/VSE8EyIAspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..ec98b6c 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -347,6 +347,48 @@
>  				status = "disabled";
>  			};
>  
> +			i2c1: i2c@40067000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x40067000 0x1000>;
> +				interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C1>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 0 52>,
> +					<&edma0 0 53>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
> +			i2c2: i2c@400e6000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x400e6000 0x1000>;
> +				interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C2>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 1 36>,
> +					<&edma0 1 37>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
> +			i2c3: i2c@400e7000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x400e7000 0x1000>;
> +				interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C3>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 1 38>,
> +					<&edma0 1 39>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
>  			clks: ccm@4006b000 {
>  				compatible = "fsl,vf610-ccm";
>  				reg = <0x4006b000 0x1000>;
> 


- -- 
Cory T. Tusar
Principal
PID 1 Solutions, Inc.
(814) 553-8619


"There are two ways of constructing a software design.  One way is to
 make it so simple that there are obviously no deficiencies, and the
 other way is to make it so complicated that there are no obvious
 deficiencies."  --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlVcjL0ACgkQHT1tsfGwHJ9szACfVfARbngdf0C1ZjNSvzzIMwlW
eAkAn2ne/PAOKBZVH/L4FP0Qmi+GWJLu
=FpuI
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Cory Tusar <cory.tusar@pid1solutions.com>
To: shawn.guo@linaro.org, kernel@pengutronix.de, stefan@agner.ch
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	mirza.krak@hostmobility.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available busses.
Date: Wed, 20 May 2015 09:31:41 -0400	[thread overview]
Message-ID: <555C8CBD.7000007@pid1solutions.com> (raw)
In-Reply-To: <1432089939-1086-1-git-send-email-cory.tusar@pid1solutions.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/19/2015 10:45 PM, Cory Tusar wrote:
> This commit extends the existing Vybrid I2C support to cover busses
> I2C1, I2C2, and I2C3.

And...I'm going to NAK my version of this patch - the i2c2 and i2c3
mappings should be under aips1 rather than aips0.

Also, I see that Stefan has a similar change up in the linux-toradex
tree:

http://git.toradex.com/cgit/linux-toradex.git/commit/arch/arm/boot/dts/vfxxx.dtsi?h=toradex_vf_4.0&id=7863765e0f3d2a20a0a69e49c44c1e2f96608c8f

I'll follow-up with him directly about resolving differences in our two
implementations.

- -Cory


> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..ec98b6c 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -347,6 +347,48 @@
>  				status = "disabled";
>  			};
>  
> +			i2c1: i2c@40067000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x40067000 0x1000>;
> +				interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C1>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 0 52>,
> +					<&edma0 0 53>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
> +			i2c2: i2c@400e6000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x400e6000 0x1000>;
> +				interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C2>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 1 36>,
> +					<&edma0 1 37>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
> +			i2c3: i2c@400e7000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,vf610-i2c";
> +				reg = <0x400e7000 0x1000>;
> +				interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks VF610_CLK_I2C3>;
> +				clock-names = "ipg";
> +				dmas = <&edma0 1 38>,
> +					<&edma0 1 39>;
> +				dma-names = "rx","tx";
> +				status = "disabled";
> +			};
> +
>  			clks: ccm@4006b000 {
>  				compatible = "fsl,vf610-ccm";
>  				reg = <0x4006b000 0x1000>;
> 


- -- 
Cory T. Tusar
Principal
PID 1 Solutions, Inc.
(814) 553-8619


"There are two ways of constructing a software design.  One way is to
 make it so simple that there are obviously no deficiencies, and the
 other way is to make it so complicated that there are no obvious
 deficiencies."  --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlVcjL0ACgkQHT1tsfGwHJ9szACfVfARbngdf0C1ZjNSvzzIMwlW
eAkAn2ne/PAOKBZVH/L4FP0Qmi+GWJLu
=FpuI
-----END PGP SIGNATURE-----

  reply	other threads:[~2015-05-20 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  2:45 [PATCH] ARM: dts: vf610: Extend I2C support to all available busses Cory Tusar
2015-05-20  2:45 ` Cory Tusar
2015-05-20 13:31 ` Cory Tusar [this message]
2015-05-20 13:31   ` Cory Tusar
2015-05-20 13:31   ` Cory Tusar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555C8CBD.7000007@pid1solutions.com \
    --to=cory.tusar@pid1solutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.