All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: "Eric Bénard" <eric@eukrea.com>,
	"Otavio Salvador" <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [PATCH] kernel 3.14.28/gpiolib: Return GPIO logical value, not true value
Date: Wed, 20 May 2015 10:51:55 -0600	[thread overview]
Message-ID: <555CBBAB.9070906@mlbassoc.com> (raw)
In-Reply-To: <20150520184919.3e6b8d9b@e6520eb.localdomain>

On 2015-05-20 10:49, Eric Bénard wrote:
> Le Wed, 20 May 2015 13:34:24 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
>> On Wed, May 20, 2015 at 12:54 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>>> Previous versions of the kernel returned the logical value of
>>> GPIO signals (i.e. 0 or 1).  This patch restores this behavior.
>>>
>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>
>> I am not sure this is a correct fix. I tried to find out the commit
>> which changed the behaviour without success.
>>
>> Fabio, is it possible for you to check how mainline is behaving? and
>> more important does it need any fix?
>>
> fixed mainline by :
> 25b35da gpio: generic: clamp retured value to [0,1]
> which is not in 3.4.28

True enough, but this patch won't apply to 3.14.28 as the
code is very different.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-05-20 16:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 15:54 [PATCH] kernel 3.14.28/gpiolib: Return GPIO logical value, not true value Gary Thomas
2015-05-20 16:34 ` Otavio Salvador
2015-05-20 16:40   ` Gary Thomas
2015-05-20 16:42     ` Otavio Salvador
2015-05-20 16:49   ` Eric Bénard
2015-05-20 16:51     ` Gary Thomas [this message]
2015-05-20 16:52       ` Fabio Estevam
2015-05-20 16:57       ` Eric Bénard
2015-05-20 17:02         ` Fabio Estevam
2015-05-20 17:14           ` Gary Thomas
2015-05-20 17:26             ` Otavio Salvador
2015-05-20 17:34               ` Gary Thomas
2015-05-20 17:36                 ` Otavio Salvador
2015-05-20 17:49                   ` Fabio Estevam
2015-06-17 13:54                     ` Otavio Salvador
2015-05-20 17:26           ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555CBBAB.9070906@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=eric@eukrea.com \
    --cc=meta-freescale@yoctoproject.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.