From: Gary Thomas <gary@mlbassoc.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [PATCH] kernel 3.14.28/gpiolib: Return GPIO logical value, not true value
Date: Wed, 20 May 2015 11:34:15 -0600 [thread overview]
Message-ID: <555CC597.6070303@mlbassoc.com> (raw)
In-Reply-To: <CAP9ODKpkJtOzgtq0qNrKM5DLePKqqeBKjQ6oNWgFtWWDE4ohYg@mail.gmail.com>
On 2015-05-20 11:26, Otavio Salvador wrote:
> On Wed, May 20, 2015 at 2:14 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> On 2015-05-20 11:02, Fabio Estevam wrote:
>>>
>>> On Wed, May 20, 2015 at 1:57 PM, Eric Bénard <eric@eukrea.com> wrote:
>>>
>>>> I think it should apply easily, as gpio-generic.c is very similar
>>>> between 3.14.28 and mainline :
>>>>
>>>> 3.14.28
>>>>
>>>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/gpio/gpio-generic.c?h=linux-3.14.y&id=v3.14.28#n142
>>>>
>>>> commit 25b35da :
>>>>
>>>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpio/gpio-generic.c?id=25b35da7f4cce82271859f1b6eabd9f3bd41a2bb
>>>
>>>
>>> Yes, agreed. It is a one-line patch, so we can easily use the mainline
>>> fix.
>>>
>>
>> I concur - my change was local to just the sysfs code, but
>> this change is more correct (and already in mainline)
>
> Can you generate a proper patch for it?
>
Why not just cherry-pick from 25b35da? It then has all of the proper
signed-off-by, etc.
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2015-05-20 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:54 [PATCH] kernel 3.14.28/gpiolib: Return GPIO logical value, not true value Gary Thomas
2015-05-20 16:34 ` Otavio Salvador
2015-05-20 16:40 ` Gary Thomas
2015-05-20 16:42 ` Otavio Salvador
2015-05-20 16:49 ` Eric Bénard
2015-05-20 16:51 ` Gary Thomas
2015-05-20 16:52 ` Fabio Estevam
2015-05-20 16:57 ` Eric Bénard
2015-05-20 17:02 ` Fabio Estevam
2015-05-20 17:14 ` Gary Thomas
2015-05-20 17:26 ` Otavio Salvador
2015-05-20 17:34 ` Gary Thomas [this message]
2015-05-20 17:36 ` Otavio Salvador
2015-05-20 17:49 ` Fabio Estevam
2015-06-17 13:54 ` Otavio Salvador
2015-05-20 17:26 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555CC597.6070303@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.