Re: [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()

From: Tobias Klausmann <tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
To: Samuel Pitoiset
	<samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()
Date: Wed, 20 May 2015 19:11:50 +0200	[thread overview]
Message-ID: <555CC056.4020006@mni.thm.de> (raw)
In-Reply-To: <1432134538-13701-1-git-send-email-samuel.pitoiset-MZpvjPyXg2s@public.gmane.org>

looks good to me! :)

Feel free to add my R-b.

On 20.05.2015 17:08, Samuel Pitoiset wrote:
> This is probably a typo error which has been introduced in 2009...
> This fixes the following warning detected by Clang :
>
> drmmode_display.c:907:30: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
>      if (props && (props->flags && DRM_MODE_PROP_ENUM)) {
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
> ---
>   src/drmmode_display.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 7c1d2bb..161bccd 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -904,7 +904,7 @@ drmmode_output_dpms(xf86OutputPtr output, int mode)
>   
>   	for (i = 0; i < koutput->count_props; i++) {
>   		props = drmModeGetProperty(drmmode->fd, koutput->props[i]);
> -		if (props && (props->flags && DRM_MODE_PROP_ENUM)) {
> +		if (props && (props->flags & DRM_MODE_PROP_ENUM)) {
>   			if (!strcmp(props->name, "DPMS")) {
>   				mode_id = koutput->props[i];
>   				drmModeFreeProperty(props);

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau