All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()
Date: Wed, 27 May 2015 13:23:37 +0200	[thread overview]
Message-ID: <5565A939.7060800@gmail.com> (raw)
In-Reply-To: <CAPM=9tyH-Xo09iAQ=0F-Vk8YtEDQkaaeLdDnmOwpDkEdC2t=sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 05/21/2015 06:40 AM, Dave Airlie wrote:
> On 21 May 2015 at 03:26, Samuel Pitoiset <samuel.pitoiset@gmail.com> wrote:
>>
>> On 05/20/2015 07:13 PM, Ilia Mirkin wrote:
>>> This is obviously a bug, but one that has been there for some time.
>>> Please figure out what this is guarding, and confirm that the feature
>>> continues to work.
>>
>> Sure, but do you have any ideas how to test this part of the DDX ?
>> It's the first time I play with it...
>>
> It's fine, the code just avoids going into the name checks if the type
> isn't a enum,
> it won't break anything actually fixing it.
>
> The fix is
>
> Reviewed-by: Dave Airlie <airlied@redhat.com>

Okay, thanks Dave.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2015-05-27 11:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 15:08 [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms() Samuel Pitoiset
     [not found] ` <1432134538-13701-1-git-send-email-samuel.pitoiset-MZpvjPyXg2s@public.gmane.org>
2015-05-20 17:11   ` Tobias Klausmann
     [not found]     ` <555CC056.4020006-AqjdNwhu20eELgA04lAiVw@public.gmane.org>
2015-05-20 17:13       ` Ilia Mirkin
     [not found]         ` <CAKb7Uvhy-o3-iAZD+EJLhhHVDGc_Zvm=-exna8waTa9QV_CVvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-20 17:26           ` Samuel Pitoiset
     [not found]             ` <555CC3C1.3010102-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-21  4:40               ` Dave Airlie
     [not found]                 ` <CAPM=9tyH-Xo09iAQ=0F-Vk8YtEDQkaaeLdDnmOwpDkEdC2t=sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-27 11:23                   ` Samuel Pitoiset [this message]
     [not found]                     ` <5565A939.7060800-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-10 21:47                       ` Samuel Pitoiset

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5565A939.7060800@gmail.com \
    --to=samuel.pitoiset-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.