* [PATCH] libata: Fix regression when the NCQ Send and Receive log page is absent
@ 2015-05-19 23:44 Martin K. Petersen
2015-05-20 20:27 ` Sergei Shtylyov
2015-05-21 21:53 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: Martin K. Petersen @ 2015-05-19 23:44 UTC (permalink / raw)
To: tj; +Cc: linux-ide, sergey.senozhatsky, Martin K. Petersen
Commit 5d3abf8ff67f allowed us to fall back to the unqueued READ LOG
variant if the queued version failed. However, if the device did not
support the page at all we would end up looping due to a merge snafu.
Ensure we only take the fallback path once.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
drivers/ata/libata-eh.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 2893563d0537..2b370ee0ae86 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1521,6 +1521,7 @@ retry:
} else {
tf.command = ATA_CMD_READ_LOG_EXT;
tf.protocol = ATA_PROT_PIO;
+ dma = false;
}
tf.lbal = log;
tf.lbam = page;
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] libata: Fix regression when the NCQ Send and Receive log page is absent
2015-05-19 23:44 [PATCH] libata: Fix regression when the NCQ Send and Receive log page is absent Martin K. Petersen
@ 2015-05-20 20:27 ` Sergei Shtylyov
2015-05-21 21:53 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-05-20 20:27 UTC (permalink / raw)
To: Martin K. Petersen, tj; +Cc: linux-ide, sergey.senozhatsky
Hello.
On 05/20/2015 02:44 AM, Martin K. Petersen wrote:
> Commit 5d3abf8ff67f allowed us to fall back to the unqueued READ LOG
Please also specify that commit's summary line in parens.
> variant if the queued version failed. However, if the device did not
> support the page at all we would end up looping due to a merge snafu.
> Ensure we only take the fallback path once.
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] libata: Fix regression when the NCQ Send and Receive log page is absent
2015-05-19 23:44 [PATCH] libata: Fix regression when the NCQ Send and Receive log page is absent Martin K. Petersen
2015-05-20 20:27 ` Sergei Shtylyov
@ 2015-05-21 21:53 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2015-05-21 21:53 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: linux-ide, sergey.senozhatsky
On Tue, May 19, 2015 at 07:44:17PM -0400, Martin K. Petersen wrote:
> Commit 5d3abf8ff67f allowed us to fall back to the unqueued READ LOG
> variant if the queued version failed. However, if the device did not
> support the page at all we would end up looping due to a merge snafu.
>
> Ensure we only take the fallback path once.
Applied w/ commit title added in the description.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-21 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 23:44 [PATCH] libata: Fix regression when the NCQ Send and Receive log page is absent Martin K. Petersen
2015-05-20 20:27 ` Sergei Shtylyov
2015-05-21 21:53 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.