* [PATCH] xfstests: correct comment in generic/135
@ 2015-05-21 0:42 Wang Sheng-Hui
2015-05-21 1:06 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Wang Sheng-Hui @ 2015-05-21 0:42 UTC (permalink / raw)
To: fstests, eguan
xfs_io '-d' specifies direct IO, not sync IO.
Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
---
tests/generic/135 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/135 b/tests/generic/135
index 79558f5..2444803 100755
--- a/tests/generic/135
+++ b/tests/generic/135
@@ -63,7 +63,7 @@ $XFS_IO_PROG -f -c 'pwrite -b 4k -S 0x12 0 4k' async_file > /dev/null
# create file with sync I/O
$XFS_IO_PROG -f -s -c 'pwrite -b 4k -S 0x34 0 4k' sync_file > /dev/null
-# create file with sync I/O
+# create file with direct I/O
$XFS_IO_PROG -f -d -c 'pwrite -b 4k -S 0x56 0 4k' direct_file > /dev/null
# create file, truncate and then dirty again
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: correct comment in generic/135
2015-05-21 0:42 [PATCH] xfstests: correct comment in generic/135 Wang Sheng-Hui
@ 2015-05-21 1:06 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2015-05-21 1:06 UTC (permalink / raw)
To: Wang Sheng-Hui, fstests, eguan
On 5/20/15 7:42 PM, Wang Sheng-Hui wrote:
> xfs_io '-d' specifies direct IO, not sync IO.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
Ok, sure. :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> tests/generic/135 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/135 b/tests/generic/135
> index 79558f5..2444803 100755
> --- a/tests/generic/135
> +++ b/tests/generic/135
> @@ -63,7 +63,7 @@ $XFS_IO_PROG -f -c 'pwrite -b 4k -S 0x12 0 4k' async_file > /dev/null
> # create file with sync I/O
> $XFS_IO_PROG -f -s -c 'pwrite -b 4k -S 0x34 0 4k' sync_file > /dev/null
>
> -# create file with sync I/O
> +# create file with direct I/O
> $XFS_IO_PROG -f -d -c 'pwrite -b 4k -S 0x56 0 4k' direct_file > /dev/null
>
> # create file, truncate and then dirty again
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-21 1:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 0:42 [PATCH] xfstests: correct comment in generic/135 Wang Sheng-Hui
2015-05-21 1:06 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.