* [Qemu-trivial] [PATCH] qemu-error: make the timestamp more obvious and clear
@ 2015-05-21 2:54 ` arei.gonglei
0 siblings, 0 replies; 6+ messages in thread
From: arei.gonglei @ 2015-05-21 2:54 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gonglei, Eric Blake
From: Gonglei <arei.gonglei@huawei.com>
before:
(qemu) 2015-05-21T02:07:43.695065Z qemu-system-x86_64: test....
after applying this patch:
(qemu) [2015-05-21T02:21:46.023619Z UTC] qemu-system-x86_64: test....
Cc: Eric Blake <eblake@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
util/qemu-error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-error.c b/util/qemu-error.c
index 9bba5f5..0b91cbc 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -212,7 +212,7 @@ void error_vreport(const char *fmt, va_list ap)
if (enable_timestamp_msg) {
g_get_current_time(&tv);
timestr = g_time_val_to_iso8601(&tv);
- error_printf("%s ", timestr);
+ error_printf("[%s UTC] ", timestr);
g_free(timestr);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] qemu-error: make the timestamp more obvious and clear
@ 2015-05-21 2:54 ` arei.gonglei
0 siblings, 0 replies; 6+ messages in thread
From: arei.gonglei @ 2015-05-21 2:54 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Gonglei
From: Gonglei <arei.gonglei@huawei.com>
before:
(qemu) 2015-05-21T02:07:43.695065Z qemu-system-x86_64: test....
after applying this patch:
(qemu) [2015-05-21T02:21:46.023619Z UTC] qemu-system-x86_64: test....
Cc: Eric Blake <eblake@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
util/qemu-error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-error.c b/util/qemu-error.c
index 9bba5f5..0b91cbc 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -212,7 +212,7 @@ void error_vreport(const char *fmt, va_list ap)
if (enable_timestamp_msg) {
g_get_current_time(&tv);
timestr = g_time_val_to_iso8601(&tv);
- error_printf("%s ", timestr);
+ error_printf("[%s UTC] ", timestr);
g_free(timestr);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] qemu-error: make the timestamp more obvious and clear
2015-05-21 2:54 ` [Qemu-devel] " arei.gonglei
@ 2015-05-21 3:07 ` Eric Blake
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2015-05-21 3:07 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]
On 05/20/2015 08:54 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> before:
> (qemu) 2015-05-21T02:07:43.695065Z qemu-system-x86_64: test....
Ah, but the trailing Z is UTC,
> after applying this patch:
> (qemu) [2015-05-21T02:21:46.023619Z UTC] qemu-system-x86_64: test....
so this representation is now redundant for specifying the same timezone
twice. Basically, 'Z', '+0000', and ' UTC' are synonyms; I don't know
if any one form is more popular than others, but I don't think we need
this patch.
>
> Cc: Eric Blake <eblake@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> util/qemu-error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index 9bba5f5..0b91cbc 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -212,7 +212,7 @@ void error_vreport(const char *fmt, va_list ap)
> if (enable_timestamp_msg) {
> g_get_current_time(&tv);
> timestr = g_time_val_to_iso8601(&tv);
Since glib already provided a trailing Z, it's actually more work to
strip it and provide an alternative of ' UTC'; so I'm inclined to NACK
this patch, unless anyone else has a strong opinion in favor of it.
> - error_printf("%s ", timestr);
> + error_printf("[%s UTC] ", timestr);
> g_free(timestr);
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-error: make the timestamp more obvious and clear
@ 2015-05-21 3:07 ` Eric Blake
0 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2015-05-21 3:07 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]
On 05/20/2015 08:54 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> before:
> (qemu) 2015-05-21T02:07:43.695065Z qemu-system-x86_64: test....
Ah, but the trailing Z is UTC,
> after applying this patch:
> (qemu) [2015-05-21T02:21:46.023619Z UTC] qemu-system-x86_64: test....
so this representation is now redundant for specifying the same timezone
twice. Basically, 'Z', '+0000', and ' UTC' are synonyms; I don't know
if any one form is more popular than others, but I don't think we need
this patch.
>
> Cc: Eric Blake <eblake@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> util/qemu-error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index 9bba5f5..0b91cbc 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -212,7 +212,7 @@ void error_vreport(const char *fmt, va_list ap)
> if (enable_timestamp_msg) {
> g_get_current_time(&tv);
> timestr = g_time_val_to_iso8601(&tv);
Since glib already provided a trailing Z, it's actually more work to
strip it and provide an alternative of ' UTC'; so I'm inclined to NACK
this patch, unless anyone else has a strong opinion in favor of it.
> - error_printf("%s ", timestr);
> + error_printf("[%s UTC] ", timestr);
> g_free(timestr);
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] qemu-error: make the timestamp more obvious and clear
2015-05-21 3:07 ` [Qemu-devel] " Eric Blake
@ 2015-05-21 3:21 ` Gonglei
-1 siblings, 0 replies; 6+ messages in thread
From: Gonglei @ 2015-05-21 3:21 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial
On 2015/5/21 11:07, Eric Blake wrote:
> On 05/20/2015 08:54 PM, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> before:
>> (qemu) 2015-05-21T02:07:43.695065Z qemu-system-x86_64: test....
>
> Ah, but the trailing Z is UTC,
>
>> after applying this patch:
>> (qemu) [2015-05-21T02:21:46.023619Z UTC] qemu-system-x86_64: test....
>
> so this representation is now redundant for specifying the same timezone
> twice. Basically, 'Z', '+0000', and ' UTC' are synonyms; I don't know
> if any one form is more popular than others, but I don't think we need
> this patch.
>
Yes, I checked it too, please ignore the noise.
Regards,
-Gonglei
>>
>> Cc: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> util/qemu-error.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/util/qemu-error.c b/util/qemu-error.c
>> index 9bba5f5..0b91cbc 100644
>> --- a/util/qemu-error.c
>> +++ b/util/qemu-error.c
>> @@ -212,7 +212,7 @@ void error_vreport(const char *fmt, va_list ap)
>> if (enable_timestamp_msg) {
>> g_get_current_time(&tv);
>> timestr = g_time_val_to_iso8601(&tv);
>
> Since glib already provided a trailing Z, it's actually more work to
> strip it and provide an alternative of ' UTC'; so I'm inclined to NACK
> this patch, unless anyone else has a strong opinion in favor of it.
>
>> - error_printf("%s ", timestr);
>> + error_printf("[%s UTC] ", timestr);
>> g_free(timestr);
>> }
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-error: make the timestamp more obvious and clear
@ 2015-05-21 3:21 ` Gonglei
0 siblings, 0 replies; 6+ messages in thread
From: Gonglei @ 2015-05-21 3:21 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial
On 2015/5/21 11:07, Eric Blake wrote:
> On 05/20/2015 08:54 PM, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> before:
>> (qemu) 2015-05-21T02:07:43.695065Z qemu-system-x86_64: test....
>
> Ah, but the trailing Z is UTC,
>
>> after applying this patch:
>> (qemu) [2015-05-21T02:21:46.023619Z UTC] qemu-system-x86_64: test....
>
> so this representation is now redundant for specifying the same timezone
> twice. Basically, 'Z', '+0000', and ' UTC' are synonyms; I don't know
> if any one form is more popular than others, but I don't think we need
> this patch.
>
Yes, I checked it too, please ignore the noise.
Regards,
-Gonglei
>>
>> Cc: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> util/qemu-error.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/util/qemu-error.c b/util/qemu-error.c
>> index 9bba5f5..0b91cbc 100644
>> --- a/util/qemu-error.c
>> +++ b/util/qemu-error.c
>> @@ -212,7 +212,7 @@ void error_vreport(const char *fmt, va_list ap)
>> if (enable_timestamp_msg) {
>> g_get_current_time(&tv);
>> timestr = g_time_val_to_iso8601(&tv);
>
> Since glib already provided a trailing Z, it's actually more work to
> strip it and provide an alternative of ' UTC'; so I'm inclined to NACK
> this patch, unless anyone else has a strong opinion in favor of it.
>
>> - error_printf("%s ", timestr);
>> + error_printf("[%s UTC] ", timestr);
>> g_free(timestr);
>> }
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-21 3:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 2:54 [Qemu-trivial] [PATCH] qemu-error: make the timestamp more obvious and clear arei.gonglei
2015-05-21 2:54 ` [Qemu-devel] " arei.gonglei
2015-05-21 3:07 ` [Qemu-trivial] " Eric Blake
2015-05-21 3:07 ` [Qemu-devel] " Eric Blake
2015-05-21 3:21 ` [Qemu-trivial] " Gonglei
2015-05-21 3:21 ` [Qemu-devel] " Gonglei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.