From: Yongbok Kim <yongbok.kim@imgtec.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, leon.alrae@imgtec.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory accesses for MSA
Date: Thu, 21 May 2015 10:47:21 +0100 [thread overview]
Message-ID: <555DA9A9.7030407@imgtec.com> (raw)
In-Reply-To: <555CC394.5080501@twiddle.net>
On 20/05/2015 18:25, Richard Henderson wrote:
>
>> + int i; \
>> + for (i = 0; i < DF_ELEMENTS(DF); i++) { \
>> + wx.TYPE[i] = LD_INSN(env, addr + (i << DF), ##__VA_ARGS__); \
>
> Why the varargs? They're the same all the time.
No, they aren't. we still need to support linux user mode which don't have
any extra argument.
MSA_LD_DF(DF_BYTE, b, helper_ret_ldub_mmu, \
make_memop_idx(MO_UNALN, cpu_mmu_index(env)), GETRA())
VS.
MSA_LD_DF(DF_BYTE, b, cpu_ldub_data)
Regards,
Yongbok
next prev parent reply other threads:[~2015-05-21 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:12 [Qemu-devel] [PATCH v4 0/3] target-mips: Add support for misaligned accesses Yongbok Kim
2015-05-20 15:12 ` [Qemu-devel] [PATCH v4 1/3] target-mips: Misaligned memory accesses for R6 Yongbok Kim
2015-05-20 17:09 ` Richard Henderson
2015-05-21 9:47 ` Yongbok Kim
2015-05-21 16:15 ` Richard Henderson
2015-05-20 15:12 ` [Qemu-devel] [PATCH v4 2/3] softmmu: Add probe_write() Yongbok Kim
2015-05-20 17:10 ` Richard Henderson
2015-05-20 15:12 ` [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory accesses for MSA Yongbok Kim
2015-05-20 17:25 ` Richard Henderson
2015-05-21 9:47 ` Yongbok Kim [this message]
2015-05-21 16:16 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555DA9A9.7030407@imgtec.com \
--to=yongbok.kim@imgtec.com \
--cc=afaerber@suse.de \
--cc=leon.alrae@imgtec.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.