All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Yinghai Lu <yinghai@kernel.org>,
	Yijing Wang <wangyijing@huawei.com>
Subject: Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
Date: Thu, 21 May 2015 23:17:55 +0800	[thread overview]
Message-ID: <555DF723.2000103@linaro.org> (raw)
In-Reply-To: <CAErSpo6kFfXd9gFuL86qQWcVN6NYe11Ps+SoAefz1z2md8j_tA@mail.gmail.com>

On 2015年05月21日 23:10, Bjorn Helgaas wrote:
> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> list_head "list" in struct acpi_prt_entry was used to connect
>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
>> Don't cache _PRT, and don't associate them with bus numbers),
>> the list head for _PRT entries was removed, but left "list" in
>> struct acpi_prt_entry which is useless and stale, remove it now.
>
> Please use the canonical commit reference format, i.e.,
>
> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
> with bus numbers")

OK, now I know what is a canonical commit reference format :)

>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> CC: Yinghai Lu <yinghai@kernel.org>
>> CC: Yijing Wang <wangyijing@huawei.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Thanks, will update the change log soon.

Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Yinghai Lu <yinghai@kernel.org>,
	Yijing Wang <wangyijing@huawei.com>
Subject: Re: [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
Date: Thu, 21 May 2015 23:17:55 +0800	[thread overview]
Message-ID: <555DF723.2000103@linaro.org> (raw)
In-Reply-To: <CAErSpo6kFfXd9gFuL86qQWcVN6NYe11Ps+SoAefz1z2md8j_tA@mail.gmail.com>

On 2015年05月21日 23:10, Bjorn Helgaas wrote:
> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> list_head "list" in struct acpi_prt_entry was used to connect
>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI:
>> Don't cache _PRT, and don't associate them with bus numbers),
>> the list head for _PRT entries was removed, but left "list" in
>> struct acpi_prt_entry which is useless and stale, remove it now.
>
> Please use the canonical commit reference format, i.e.,
>
> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them
> with bus numbers")

OK, now I know what is a canonical commit reference format :)

>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> CC: Yinghai Lu <yinghai@kernel.org>
>> CC: Yijing Wang <wangyijing@huawei.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Thanks, will update the change log soon.

Hanjun

  reply	other threads:[~2015-05-21 15:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 13:52 [PATCH] ACPI / PCI: remove stale list_head in struct acpi_prt_entry Hanjun Guo
2015-05-21 15:10 ` Bjorn Helgaas
2015-05-21 15:17   ` Hanjun Guo [this message]
2015-05-21 15:17     ` Hanjun Guo
2015-05-21 15:21     ` Bjorn Helgaas
2015-05-21 15:21       ` Bjorn Helgaas
2015-05-21 15:53       ` Bjorn Helgaas
2015-05-21 15:53         ` Bjorn Helgaas
2015-05-22 11:04         ` Hanjun Guo
2015-05-22 11:04           ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555DF723.2000103@linaro.org \
    --to=hanjun.guo@linaro.org \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=wangyijing@huawei.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.