From: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org>
To: Arto Merilainen
<amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mikko Perttunen
<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
srasal-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dnibade-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 3/4] drm/tegra: Add VIC support
Date: Thu, 21 May 2015 18:44:08 +0300 [thread overview]
Message-ID: <555DFD48.4000609@kapsi.fi> (raw)
In-Reply-To: <555DF576.7070307-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/21/2015 06:10 PM, Arto Merilainen wrote:
> ...
>>> +
>>> + vic->rst = devm_reset_control_get(dev, "vic03");
>>
>> I might prefer just "vic" as the clock/reset name. The name is often
>> used as a sort of "role" for the clock/reset for the device, not
>> necessarily the raw name of the "correct" clock/reset.
>>
>
> I considered that - but I then noticed that
> drivers/clk/tegra/clk-tegra124.c was already using vic03 variant. I can
> write a patch for changing that too.
Well, the two can be different; the clock-name in device tree kind of
means "string that i use to refer to a clock that powers the VIC unit".
It's not really a big deal though, both ways are used in DT bindings.
Mikko
WARNING: multiple messages have this Message-ID (diff)
From: Mikko Perttunen <mikko.perttunen@kapsi.fi>
To: Arto Merilainen <amerilainen@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, achew@nvidia.com,
srasal@nvidia.com, dnibade@nvidia.com
Subject: Re: [PATCH 3/4] drm/tegra: Add VIC support
Date: Thu, 21 May 2015 18:44:08 +0300 [thread overview]
Message-ID: <555DFD48.4000609@kapsi.fi> (raw)
In-Reply-To: <555DF576.7070307@nvidia.com>
On 05/21/2015 06:10 PM, Arto Merilainen wrote:
> ...
>>> +
>>> + vic->rst = devm_reset_control_get(dev, "vic03");
>>
>> I might prefer just "vic" as the clock/reset name. The name is often
>> used as a sort of "role" for the clock/reset for the device, not
>> necessarily the raw name of the "correct" clock/reset.
>>
>
> I considered that - but I then noticed that
> drivers/clk/tegra/clk-tegra124.c was already using vic03 variant. I can
> write a patch for changing that too.
Well, the two can be different; the clock-name in device tree kind of
means "string that i use to refer to a clock that powers the VIC unit".
It's not really a big deal though, both ways are used in DT bindings.
Mikko
next prev parent reply other threads:[~2015-05-21 15:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:20 [PATCH 0/4] Add VIC support for Tegra124 Arto Merilainen
2015-05-21 13:20 ` Arto Merilainen
2015-05-21 13:20 ` [PATCH 1/4] host1x: Store device address to all bufs Arto Merilainen
2015-05-21 13:20 ` Arto Merilainen
2015-05-21 13:20 ` [PATCH 2/4] host1x: Pass register value in firewall Arto Merilainen
2015-05-21 13:20 ` Arto Merilainen
2015-05-21 13:20 ` [PATCH 3/4] drm/tegra: Add VIC support Arto Merilainen
2015-05-21 13:20 ` Arto Merilainen
[not found] ` <1432214425-27137-4-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-05-21 14:40 ` Mikko Perttunen
2015-05-21 14:40 ` Mikko Perttunen
[not found] ` <555DEE5F.2060100-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-05-21 15:10 ` Arto Merilainen
2015-05-21 15:10 ` Arto Merilainen
[not found] ` <555DF576.7070307-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-05-21 15:44 ` Mikko Perttunen [this message]
2015-05-21 15:44 ` Mikko Perttunen
[not found] ` <555DFD48.4000609-/1wQRMveznE@public.gmane.org>
2015-05-22 10:02 ` Thierry Reding
2015-05-22 10:02 ` Thierry Reding
2015-05-22 10:12 ` Arto Merilainen
2015-05-22 10:12 ` Arto Merilainen
2015-05-22 10:13 ` Arto Merilainen
2015-05-22 10:13 ` Arto Merilainen
2015-05-22 10:25 ` Thierry Reding
2015-05-22 10:25 ` Thierry Reding
2015-05-25 7:11 ` Arto Merilainen
2015-05-25 7:11 ` Arto Merilainen
2015-05-22 11:47 ` Thierry Reding
2015-05-22 11:47 ` Thierry Reding
2015-05-25 8:25 ` Arto Merilainen
2015-05-25 8:25 ` Arto Merilainen
2015-05-21 13:20 ` [PATCH 4/4] ARM: tegra: Add VIC for Tegra124 Arto Merilainen
2015-05-21 13:20 ` Arto Merilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555DFD48.4000609@kapsi.fi \
--to=mikko.perttunen-/1wqrmvezne@public.gmane.org \
--cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dnibade-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=srasal-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.