From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] NVMe: Avoid interrupt disable during queue init.
Date: Thu, 21 May 2015 12:39:18 -0600 [thread overview]
Message-ID: <555E2656.5030503@kernel.dk> (raw)
In-Reply-To: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com>
On 05/21/2015 06:12 PM, Parav Pandit wrote:
> Avoid diabling interrupt and holding q_lock for the queue
> which is just getting initialized.
>
> With this change, online_queues is also incremented without
> lock during queue setup stage.
> if Power management nvme_suspend() kicks in during queue setup time,
> per nvmeq based q_lock spinlock cannot protect device wide
> online_queues variable anyway.
Seems fairly pointless, it's not like it's a hot path...
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Parav Pandit <parav.pandit@avagotech.com>,
linux-nvme@lists.infradead.org, willy@linux.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Avoid interrupt disable during queue init.
Date: Thu, 21 May 2015 12:39:18 -0600 [thread overview]
Message-ID: <555E2656.5030503@kernel.dk> (raw)
In-Reply-To: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com>
On 05/21/2015 06:12 PM, Parav Pandit wrote:
> Avoid diabling interrupt and holding q_lock for the queue
> which is just getting initialized.
>
> With this change, online_queues is also incremented without
> lock during queue setup stage.
> if Power management nvme_suspend() kicks in during queue setup time,
> per nvmeq based q_lock spinlock cannot protect device wide
> online_queues variable anyway.
Seems fairly pointless, it's not like it's a hot path...
--
Jens Axboe
next prev parent reply other threads:[~2015-05-21 18:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 0:12 [PATCH] NVMe: Avoid interrupt disable during queue init Parav Pandit
2015-05-22 0:12 ` Parav Pandit
2015-05-21 18:39 ` Jens Axboe [this message]
2015-05-21 18:39 ` Jens Axboe
2015-05-21 19:14 ` Parav Pandit
2015-05-21 19:14 ` Parav Pandit
2015-05-21 19:34 ` Keith Busch
2015-05-21 19:34 ` Keith Busch
2015-05-22 4:15 ` Parav Pandit
2015-05-22 4:15 ` Parav Pandit
2015-05-22 14:48 ` Keith Busch
2015-05-22 14:48 ` Keith Busch
2015-05-22 14:51 ` Parav Pandit
2015-05-22 14:51 ` Parav Pandit
2015-05-22 15:11 ` Keith Busch
2015-05-22 15:11 ` Keith Busch
2015-05-22 16:03 ` Parav Pandit
2015-05-22 16:03 ` Parav Pandit
2015-05-22 16:23 ` Keith Busch
2015-05-22 16:23 ` Keith Busch
2015-05-22 16:48 ` Parav Pandit
2015-05-22 16:48 ` Parav Pandit
2015-05-22 17:07 ` Keith Busch
2015-05-22 17:07 ` Keith Busch
2015-05-22 17:33 ` Parav Pandit
2015-05-22 17:33 ` Parav Pandit
2015-05-22 17:47 ` Keith Busch
2015-05-22 17:47 ` Keith Busch
2015-05-22 18:18 ` Parav Pandit
2015-05-22 18:18 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E2656.5030503@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.