From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] extcon: fix phy-tahvo driver for extcon API change
Date: Fri, 22 May 2015 11:28:33 +0900 [thread overview]
Message-ID: <555E9451.2010504@samsung.com> (raw)
In-Reply-To: <4940971.fmN098LqHi@wuerfel>
Dear Felipe,
If you review this patch, I'll apply it on extcon tree.
Best Regards,
Chanwoo Choi
On 05/21/2015 06:39 PM, Arnd Bergmann wrote:
> Today, the API for the extcon drivers was changed, along
> with all drivers in drivers/extcon. However, one extcon driver
> instead lives in drivers/usb/phy/ and did not get change.
>
> Gcc warns about the now incorrect API usage:
>
> drivers/usb/phy/phy-tahvo.c: In function 'tahvo_usb_probe':
> drivers/usb/phy/phy-tahvo.c:368:29: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
> tu->extcon.supported_cable = tahvo_cable;
>
> This changes the API in the same way as the other drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 17cd440c9acc ("extcon: Update the prototype of extcon_register_notifier() with enum extcon")
> ---
> As the API change is only present in the extcon tree, this patch should get
> merged there as well, not in the usb-phy tree.
>
> If possible, please fold into the original commit.
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index 845f658276b1..1d1bb9ad8ccf 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -60,10 +60,11 @@ struct tahvo_usb {
> struct extcon_dev extcon;
> };
>
> -static const char *tahvo_cable[] = {
> - "USB-HOST",
> - "USB",
> - NULL,
> +static const enum extcon tahvo_cable[] = {
> + EXTCON_USB,
> + EXTCON_USB_HOST,
> +
> + EXTCON_NONE,
> };
>
> static ssize_t vbus_state_show(struct device *device,
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] extcon: fix phy-tahvo driver for extcon API change
Date: Fri, 22 May 2015 11:28:33 +0900 [thread overview]
Message-ID: <555E9451.2010504@samsung.com> (raw)
In-Reply-To: <4940971.fmN098LqHi@wuerfel>
Dear Felipe,
If you review this patch, I'll apply it on extcon tree.
Best Regards,
Chanwoo Choi
On 05/21/2015 06:39 PM, Arnd Bergmann wrote:
> Today, the API for the extcon drivers was changed, along
> with all drivers in drivers/extcon. However, one extcon driver
> instead lives in drivers/usb/phy/ and did not get change.
>
> Gcc warns about the now incorrect API usage:
>
> drivers/usb/phy/phy-tahvo.c: In function 'tahvo_usb_probe':
> drivers/usb/phy/phy-tahvo.c:368:29: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
> tu->extcon.supported_cable = tahvo_cable;
>
> This changes the API in the same way as the other drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 17cd440c9acc ("extcon: Update the prototype of extcon_register_notifier() with enum extcon")
> ---
> As the API change is only present in the extcon tree, this patch should get
> merged there as well, not in the usb-phy tree.
>
> If possible, please fold into the original commit.
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index 845f658276b1..1d1bb9ad8ccf 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -60,10 +60,11 @@ struct tahvo_usb {
> struct extcon_dev extcon;
> };
>
> -static const char *tahvo_cable[] = {
> - "USB-HOST",
> - "USB",
> - NULL,
> +static const enum extcon tahvo_cable[] = {
> + EXTCON_USB,
> + EXTCON_USB_HOST,
> +
> + EXTCON_NONE,
> };
>
> static ssize_t vbus_state_show(struct device *device,
>
>
next prev parent reply other threads:[~2015-05-22 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 9:39 [PATCH] extcon: fix phy-tahvo driver for extcon API change Arnd Bergmann
2015-05-21 9:39 ` Arnd Bergmann
2015-05-22 2:28 ` Chanwoo Choi [this message]
2015-05-22 2:28 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E9451.2010504@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.