Re: [PATCH bluetooth-next 4/4] mac802154: use atomic ops for sequence incrementation

[Stefan Schmidt <stefan@osg.samsung.com>]

Hello.

On 22/05/15 12:34, Marc Kleine-Budde wrote:
> On 05/22/2015 12:30 PM, Stefan Schmidt wrote:
>> Hello.
>>
>> On 22/05/15 10:59, Marc Kleine-Budde wrote:
>>> On 05/22/2015 10:57 AM, Alexander Aring wrote:
>>>> This patch will use atomic operations for sequence number incrementation
>>>> while MAC header generation. Upper layers like af_802154 or 6LoWPAN
>>>> could call this function in a parallel context while generating 802.15.4
>>>> MAC header before queuing into wpan interfaces transmit queue.
>>> what about swapping patch 3 and 4?
>> To avoid having problems during a git bisect later one? E.g. having the
>> lock removed but no atomic in place?
> Yes, that's what I was thinking about. I don't know the code to tell if
> this is an issue here.

A good point. I'm not sure either. I would say we could play safe and 
swap them. Alex, guess its your final call as you know the code best 
from us. Could we have problems with the locks removed but the atomic 
patch not applied (as it could happen with git bisect right now)? If 
yes, swapping them makes sense to avoid this.

Btw, I'm running some light testing with 6lowpan pings with these four 
patches applied right now. Looks good so far. Will send another mail 
once its done.

regards
Stefan Schmidt