From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com,
eddie.dong@intel.com, stefano.stabellini@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, jun.nakajima@intel.com, keir@xen.org,
ian.campbell@citrix.com
Subject: Re: [PATCH V4] xen/vm_event: Clean up control-register-write vm_events
Date: Fri, 22 May 2015 15:45:04 +0300 [thread overview]
Message-ID: <555F24D0.3040705@bitdefender.com> (raw)
In-Reply-To: <555F3BB8020000780007D43D@mail.emea.novell.com>
On 05/22/2015 03:22 PM, Jan Beulich wrote:
>>>> On 22.05.15 at 14:15, <rcojocaru@bitdefender.com> wrote:
>> While working on this I found the following in the vm_event.h header:
>>
>> 168 struct vm_event_debug {
>> 169 uint64_t gfn;
>> 170 uint32_t _pad;
>> 171 };
>>
>> Is this supposed to be 64 + 32 bits padding?
>
> I think I need to direct the question back to you.
Fair enough, let me rephrase that: I don't see how that padding would be
useful, and I propose to remove _pad as part of the next version of this
patch (or a different smaller patch).
Thanks,
Razvan
next prev parent reply other threads:[~2015-05-22 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:00 [PATCH V4] xen/vm_event: Clean up control-register-write vm_events Razvan Cojocaru
2015-05-21 13:18 ` Razvan Cojocaru
2015-05-22 7:36 ` Jan Beulich
2015-05-22 7:50 ` Razvan Cojocaru
2015-05-22 8:03 ` Jan Beulich
2015-05-22 12:15 ` Razvan Cojocaru
2015-05-22 12:22 ` Jan Beulich
2015-05-22 12:45 ` Razvan Cojocaru [this message]
2015-05-22 12:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F24D0.3040705@bitdefender.com \
--to=rcojocaru@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.