All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.
Date: Fri, 22 May 2015 07:01:10 -0600	[thread overview]
Message-ID: <555F2896.60407@mlbassoc.com> (raw)
In-Reply-To: <CAGXeWgmdmiY0eVzpBKLbxp1QCZGSQ9HuF20PRD8ew9x96+fuug@mail.gmail.com>

On 2015-05-22 06:49, Thomas PERROT wrote:
> Hi Gary,
>
> I know it is incorrect to define this variable in a no machine layer
> but that can be possible.
>
> For example, by using the meta-systemd layer, the recipe
> systemd-serialgetty define SERIAL_CONSOLE, so when the raspberrypi
> machine layer is applied, the SERIAL_CONSOLE isn't changed and the
> value is invalid.
>
> I know that it's incorrect for the meta-systemd layer to define this
> variable, so I have submit a another patch to fix it.
>
> But I think replace "?=" by "=" in raspberrypi machine layer is more robust.
>
> I also send this patch on the rpi mailing list.

IMO, the best solution would be to replace it totally since SERIAL_CONSOLE
is deprecated by SERIAL_CONSOLES.  It should probably be:
   SERIAL_CONSOLES ?= "115200;ttyAMA0"

> On Fri, May 22, 2015 at 1:23 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> On 2015-05-22 04:04, Thomas Perrot wrote:
>>>
>>> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
>>> ---
>>>    conf/machine/include/rpi-base.inc |    2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/conf/machine/include/rpi-base.inc
>>> b/conf/machine/include/rpi-base.inc
>>> index a26803a..1dda207 100644
>>> --- a/conf/machine/include/rpi-base.inc
>>> +++ b/conf/machine/include/rpi-base.inc
>>> @@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
>>>
>>>    IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
>>>
>>> -SERIAL_CONSOLE ?= "115200 ttyAMA0"
>>> +SERIAL_CONSOLE = "115200 ttyAMA0"
>>>
>>>    XSERVER = " \
>>>        xserver-xorg \
>>>
>>
>> Firstly, this should go to the RaspberryPi list (CC'd), not here.
>>
>> How can this value, which is only ever defined in this file
>> when using MACHINE=raspberrypi* be affected by another layer?
>> Is there is another layer which is defining this variable
>> outside of the MACHINE .conf files, then that layer is incorrect,
>> not this one.
>>
>> --
>> ------------------------------------------------------------
>> Gary Thomas                 |  Consulting for the
>> MLB Associates              |    Embedded world
>> ------------------------------------------------------------
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-05-22 13:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 10:04 [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good Thomas Perrot
2015-05-22 11:23 ` Gary Thomas
2015-05-22 12:49   ` Thomas PERROT
2015-05-22 13:01     ` Gary Thomas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-22 10:03 Thomas Perrot
2015-06-05 14:52 ` Andrei Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555F2896.60407@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.