[meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[Thomas Perrot]

Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
---
 conf/machine/include/rpi-base.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc
index a26803a..1dda207 100644
--- a/conf/machine/include/rpi-base.inc
+++ b/conf/machine/include/rpi-base.inc
@@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
 
 IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
 
-SERIAL_CONSOLE ?= "115200 ttyAMA0"
+SERIAL_CONSOLE = "115200 ttyAMA0"
 
 XSERVER = " \
     xserver-xorg \
-- 
1.7.10.4

[meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[Thomas Perrot]

Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
---
 conf/machine/include/rpi-base.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc
index a26803a..1dda207 100644
--- a/conf/machine/include/rpi-base.inc
+++ b/conf/machine/include/rpi-base.inc
@@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
 
 IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
 
-SERIAL_CONSOLE ?= "115200 ttyAMA0"
+SERIAL_CONSOLE = "115200 ttyAMA0"
 
 XSERVER = " \
     xserver-xorg \
-- 
1.7.10.4

Re: [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[Gary Thomas]

On 2015-05-22 04:04, Thomas Perrot wrote:
> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
> ---
>   conf/machine/include/rpi-base.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc
> index a26803a..1dda207 100644
> --- a/conf/machine/include/rpi-base.inc
> +++ b/conf/machine/include/rpi-base.inc
> @@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
>
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
>
> -SERIAL_CONSOLE ?= "115200 ttyAMA0"
> +SERIAL_CONSOLE = "115200 ttyAMA0"
>
>   XSERVER = " \
>       xserver-xorg \
>

Firstly, this should go to the RaspberryPi list (CC'd), not here.

How can this value, which is only ever defined in this file
when using MACHINE=raspberrypi* be affected by another layer?
Is there is another layer which is defining this variable
outside of the MACHINE .conf files, then that layer is incorrect,
not this one.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[Thomas PERROT]

Hi Gary,

I know it is incorrect to define this variable in a no machine layer
but that can be possible.

For example, by using the meta-systemd layer, the recipe
systemd-serialgetty define SERIAL_CONSOLE, so when the raspberrypi
machine layer is applied, the SERIAL_CONSOLE isn't changed and the
value is invalid.

I know that it's incorrect for the meta-systemd layer to define this
variable, so I have submit a another patch to fix it.

But I think replace "?=" by "=" in raspberrypi machine layer is more robust.

I also send this patch on the rpi mailing list.

Best regards,
Thomas P.

On Fri, May 22, 2015 at 1:23 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> On 2015-05-22 04:04, Thomas Perrot wrote:
>>
>> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
>> ---
>>   conf/machine/include/rpi-base.inc |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/conf/machine/include/rpi-base.inc
>> b/conf/machine/include/rpi-base.inc
>> index a26803a..1dda207 100644
>> --- a/conf/machine/include/rpi-base.inc
>> +++ b/conf/machine/include/rpi-base.inc
>> @@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
>>
>>   IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
>>
>> -SERIAL_CONSOLE ?= "115200 ttyAMA0"
>> +SERIAL_CONSOLE = "115200 ttyAMA0"
>>
>>   XSERVER = " \
>>       xserver-xorg \
>>
>
> Firstly, this should go to the RaspberryPi list (CC'd), not here.
>
> How can this value, which is only ever defined in this file
> when using MACHINE=raspberrypi* be affected by another layer?
> Is there is another layer which is defining this variable
> outside of the MACHINE .conf files, then that layer is incorrect,
> not this one.
>
> --
> ------------------------------------------------------------
> Gary Thomas                 |  Consulting for the
> MLB Associates              |    Embedded world
> ------------------------------------------------------------
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[Gary Thomas]

On 2015-05-22 06:49, Thomas PERROT wrote:
> Hi Gary,
>
> I know it is incorrect to define this variable in a no machine layer
> but that can be possible.
>
> For example, by using the meta-systemd layer, the recipe
> systemd-serialgetty define SERIAL_CONSOLE, so when the raspberrypi
> machine layer is applied, the SERIAL_CONSOLE isn't changed and the
> value is invalid.
>
> I know that it's incorrect for the meta-systemd layer to define this
> variable, so I have submit a another patch to fix it.
>
> But I think replace "?=" by "=" in raspberrypi machine layer is more robust.
>
> I also send this patch on the rpi mailing list.

IMO, the best solution would be to replace it totally since SERIAL_CONSOLE
is deprecated by SERIAL_CONSOLES.  It should probably be:
   SERIAL_CONSOLES ?= "115200;ttyAMA0"

> On Fri, May 22, 2015 at 1:23 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> On 2015-05-22 04:04, Thomas Perrot wrote:
>>>
>>> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
>>> ---
>>>    conf/machine/include/rpi-base.inc |    2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/conf/machine/include/rpi-base.inc
>>> b/conf/machine/include/rpi-base.inc
>>> index a26803a..1dda207 100644
>>> --- a/conf/machine/include/rpi-base.inc
>>> +++ b/conf/machine/include/rpi-base.inc
>>> @@ -7,7 +7,7 @@ include conf/machine/include/soc-family.inc
>>>
>>>    IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
>>>
>>> -SERIAL_CONSOLE ?= "115200 ttyAMA0"
>>> +SERIAL_CONSOLE = "115200 ttyAMA0"
>>>
>>>    XSERVER = " \
>>>        xserver-xorg \
>>>
>>
>> Firstly, this should go to the RaspberryPi list (CC'd), not here.
>>
>> How can this value, which is only ever defined in this file
>> when using MACHINE=raspberrypi* be affected by another layer?
>> Is there is another layer which is defining this variable
>> outside of the MACHINE .conf files, then that layer is incorrect,
>> not this one.
>>
>> --
>> ------------------------------------------------------------
>> Gary Thomas                 |  Consulting for the
>> MLB Associates              |    Embedded world
>> ------------------------------------------------------------
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-raspberrypi][PATCH] If SERIAL_CONSOLE is already define by another layer, this value may not be good.

[Andrei Gherzan]

On Fri, May 22, 2015 at 12:03:55PM +0200, Thomas Perrot wrote:
> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>

Merged to master. Thank you.

--
Andrei Gherzan