From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] systemd-serialgetty: Remove SERIAL_CONSOLE definition, because it depends of machine definition. Set it, here, can be make the value is not good.
Date: Fri, 22 May 2015 07:08:55 -0600 [thread overview]
Message-ID: <555F2A67.5080904@mlbassoc.com> (raw)
In-Reply-To: <CAP9ODKprXP3_O41a7HAenLXPuJAGTOz0_1bF0xyud+vRvxJcRA@mail.gmail.com>
On 2015-05-22 05:11, Otavio Salvador wrote:
> On Fri, May 22, 2015 at 7:09 AM, Thomas Perrot <thomas.perrot@tupi.fr> wrote:
>> Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
>
> Nack! The setting here is the default if machine does not define it. I
> see no benefit in dropping this.
>
I disagree - if this variable needs a value then it should be
an error to not have one assigned. Adding a default in an obscure
recipe (which would not have a useful value for many/most targets)
is simply wrong.
Also SERIAL_CONSOLE should now replaced by SERIAL_CONSOLES...
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
prev parent reply other threads:[~2015-05-22 13:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 10:09 [PATCH] systemd-serialgetty: Remove SERIAL_CONSOLE definition, because it depends of machine definition. Set it, here, can be make the value is not good Thomas Perrot
2015-05-22 11:11 ` Otavio Salvador
2015-05-22 13:02 ` Thomas PERROT
2015-05-22 13:12 ` Paul Eggleton
2015-05-22 13:28 ` Gary Thomas
2015-05-22 13:32 ` Paul Eggleton
2015-05-22 13:57 ` Gary Thomas
2015-05-22 13:58 ` Thomas PERROT
2015-05-22 14:06 ` Paul Eggleton
2015-05-22 14:27 ` Thomas PERROT
2015-05-22 14:32 ` Paul Eggleton
2015-05-22 15:20 ` Thomas PERROT
2015-05-22 17:02 ` Thomas PERROT
2015-05-22 13:08 ` Gary Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F2A67.5080904@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.