Re: [PATCH] systemd-serialgetty: Remove SERIAL_CONSOLE definition, because it depends of machine definition. Set it, here, can be make the value is not good.

[Gary Thomas <gary@mlbassoc.com>]

On 2015-05-22 07:12, Paul Eggleton wrote:
> Hi Thomas,
>
> On Friday 22 May 2015 15:02:02 Thomas PERROT wrote:
>> If the machine layer definition is applied after meta-systemd also
>> with a default setting operator instead an affectation, this var will
>> be bad initialized. It's the case with meta-raspberrypi layer.
>
> 1) Where in meta-systemd is SERIAL_CONSOLE being set? I can't find it anywhere
> in there.

It's actually in OE-core:
   meta/recipes-core/systemd/systemd-serialgetty.bb

>
> 2) Should you even be using meta-systemd? systemd support in OE-Core is 99%
> complete; meta-systemd is mostly only needed for legacy usages.
>
> 3) When the machine configuration sets the value, that happens pretty early on
> in the parsing process so there's no way that this value is going to take
> precedence over the machine value. Have you looked at the output of
> bitbake -e systemd-serialgetty | less to see how the value of this variable is
> being set?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------