* [PATCH] lvconvert: change how to get failed mirrors number
@ 2015-05-22 7:50 Lidong Zhong
2015-05-22 13:40 ` Zdenek Kabelac
0 siblings, 1 reply; 2+ messages in thread
From: Lidong Zhong @ 2015-05-22 7:50 UTC (permalink / raw)
To: lvm-devel
It's probably a typo since the segment type can't be AREA_LV and AREA_PV
simultaneously.
Signed-off-by: Lidong Zhong <lzhong@suse.com>
---
tools/lvconvert.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 6e47f81..4c0cb10 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -839,10 +839,10 @@ static int _failed_mirrors_count(struct logical_volume *lv)
ret += _failed_mirrors_count(seg_lv(lvseg, s));
else if (seg_lv(lvseg, s)->status & PARTIAL_LV)
++ ret;
- else if (seg_type(lvseg, s) == AREA_PV &&
- is_missing_pv(seg_pv(lvseg, s)))
- ++ret;
}
+ else if (seg_type(lvseg, s) == AREA_PV &&
+ is_missing_pv(seg_pv(lvseg, s)))
+ ++ret;
}
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] lvconvert: change how to get failed mirrors number
2015-05-22 7:50 [PATCH] lvconvert: change how to get failed mirrors number Lidong Zhong
@ 2015-05-22 13:40 ` Zdenek Kabelac
0 siblings, 0 replies; 2+ messages in thread
From: Zdenek Kabelac @ 2015-05-22 13:40 UTC (permalink / raw)
To: lvm-devel
Dne 22.5.2015 v 09:50 Lidong Zhong napsal(a):
> It's probably a typo since the segment type can't be AREA_LV and AREA_PV
> simultaneously.
>
Thanks for noticing - went upstream as:
https://www.redhat.com/archives/lvm-devel/2015-May/msg00211.html
Regards
Zdenek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-22 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-22 7:50 [PATCH] lvconvert: change how to get failed mirrors number Lidong Zhong
2015-05-22 13:40 ` Zdenek Kabelac
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.