Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On 05/22/2015 01:22 PM, Thomas Huth wrote:
> So far, it is not possible to use the network dump interface
> with the "-netdev" option yet, it only works with the legacy
> "-net" option. To be able to use it with "-netdev", too, this
> patch now enables the "vlan" packet distribution for the
> "-netdev" option, too, so that you can now dump network packets
> like this:
> 
> qemu... -device e1000,netdev=myhub -netdev hubport,hubid=1,id=myhub \
>         -netdev user,id=n1,vlan=1,tftp=/tmp/tftp,bootfile=zImage \
>         -netdev dump,id=n2,vlan=1,file=/tmp/dump.dat
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---

> +++ b/qapi-schema.json
> @@ -2512,6 +2512,7 @@
>  { 'struct': 'Netdev',
>    'data': {
>      'id':   'str',
> +    '*vlan': 'int32',
>      'opts': 'NetClientOptions' } }

Needs a documentation blurb for the new parameter, including '#optional'
and '(since 2.4)' markings.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]