All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,
Date: Tue, 26 May 2015 20:25:21 +0200	[thread overview]
Message-ID: <5564BA91.60708@redhat.com> (raw)
In-Reply-To: <20150526150714.24b2cf8f@thh440s>



On 26/05/2015 15:07, Thomas Huth wrote:
> Certainly no objections from my side to keep this "vlan" concept in
> QEMU, but thinking about this option again, I'd rather call it "hub=xx"
> for the -netdev option instead of "vlan=xx", since this better matches
> the "-netdev hubport" naming and it IMHO also describes the
> functionality in a better way.
> (of course I also need to add proper updates to the documentation files
> in my patch in that way)

I agree.  It makes sense, because vlans have other uses besides dump
(e.g. connecting VMs via the socket or l2tpv3 backends, where VMs have
multiple NICs).

Paolo

  reply	other threads:[~2015-05-26 18:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 19:22 [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too, Thomas Huth
2015-05-22 19:42 ` Eric Blake
2015-05-26 12:52 ` Stefan Hajnoczi
2015-05-26 13:07   ` Thomas Huth
2015-05-26 18:25     ` Paolo Bonzini [this message]
2015-05-26 14:29   ` Markus Armbruster
2015-05-26 14:36     ` Daniel P. Berrange
2015-05-26 16:43       ` Stefan Hajnoczi
2015-05-26 18:15         ` Thomas Huth
2015-05-27  7:22           ` Markus Armbruster
2015-07-17  6:53     ` [Qemu-devel] net: Next steps to deprecate -net (was: [RFC PATCH] Enable vlans and dump for -netdev, too) Thomas Huth
2015-07-17  7:25       ` Peter Maydell
2015-07-17  7:48         ` [Qemu-devel] net: Next steps to deprecate -net Thomas Huth
2015-07-22 13:40           ` Markus Armbruster
2015-07-22 16:20             ` Michael S. Tsirkin
2015-07-22 16:45               ` Thomas Huth
2015-07-17  8:16       ` [Qemu-devel] net: Next steps to deprecate -net (was: [RFC PATCH] Enable vlans and dump for -netdev, too) Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5564BA91.60708@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.