* [Cocci] [PATCH] coccinelle: irqf_oneshot.cocci: Improve the generated commit log
@ 2015-05-24 20:45 Fabio Estevam
2015-05-25 6:21 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2015-05-24 20:45 UTC (permalink / raw)
To: cocci
From: Fabio Estevam <fabio.estevam@freescale.com>
Improve the commit log of the generated patch by mentioning the commit
log that makes threaded IRQs without a primary handler to be requested
with the IRQF_ONESHOT flag.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
scripts/coccinelle/misc/irqf_oneshot.cocci | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
index b17ac8b..b421150 100644
--- a/scripts/coccinelle/misc/irqf_oneshot.cocci
+++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
@@ -1,5 +1,8 @@
-/// Make sure threaded IRQs without a primary handler are always requested with
-/// IRQF_ONESHOT
+/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
+/// threaded IRQs without a primary handler need to be requested with
+/// IRQF_ONESHOT, otherwise the request will fail.
+///
+/// So pass the IRQF_ONESHOT flag in this case.
///
//
// Confidence: Good
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Cocci] [PATCH] coccinelle: irqf_oneshot.cocci: Improve the generated commit log
2015-05-24 20:45 [Cocci] [PATCH] coccinelle: irqf_oneshot.cocci: Improve the generated commit log Fabio Estevam
@ 2015-05-25 6:21 ` Julia Lawall
2015-05-25 6:30 ` Valentin Rothberg
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2015-05-25 6:21 UTC (permalink / raw)
To: cocci
Valentin? (It's his semantic patch)
julia
On Sun, 24 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Improve the commit log of the generated patch by mentioning the commit
> log that makes threaded IRQs without a primary handler to be requested
> with the IRQF_ONESHOT flag.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> scripts/coccinelle/misc/irqf_oneshot.cocci | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> index b17ac8b..b421150 100644
> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
> @@ -1,5 +1,8 @@
> -/// Make sure threaded IRQs without a primary handler are always requested with
> -/// IRQF_ONESHOT
> +/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> +/// threaded IRQs without a primary handler need to be requested with
> +/// IRQF_ONESHOT, otherwise the request will fail.
> +///
> +/// So pass the IRQF_ONESHOT flag in this case.
> ///
> //
> // Confidence: Good
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cocci] [PATCH] coccinelle: irqf_oneshot.cocci: Improve the generated commit log
2015-05-25 6:21 ` Julia Lawall
@ 2015-05-25 6:30 ` Valentin Rothberg
2015-05-25 8:24 ` Michal Marek
0 siblings, 1 reply; 4+ messages in thread
From: Valentin Rothberg @ 2015-05-25 6:30 UTC (permalink / raw)
To: cocci
On Mon, May 25, 2015 at 8:21 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> Valentin? (It's his semantic patch)
>
> julia
>
> On Sun, 24 May 2015, Fabio Estevam wrote:
>
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Improve the commit log of the generated patch by mentioning the commit
>> log that makes threaded IRQs without a primary handler to be requested
>> with the IRQF_ONESHOT flag.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> scripts/coccinelle/misc/irqf_oneshot.cocci | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> index b17ac8b..b421150 100644
>> --- a/scripts/coccinelle/misc/irqf_oneshot.cocci
>> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
>> @@ -1,5 +1,8 @@
>> -/// Make sure threaded IRQs without a primary handler are always requested with
>> -/// IRQF_ONESHOT
>> +/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
>> +/// threaded IRQs without a primary handler need to be requested with
>> +/// IRQF_ONESHOT, otherwise the request will fail.
>> +///
>> +/// So pass the IRQF_ONESHOT flag in this case.
>> ///
>> //
>> // Confidence: Good
>> --
>> 1.9.1
>>
>>
Acked- by: Valentin Rothberg <valentinrothberg@gmail.com>
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cocci] [PATCH] coccinelle: irqf_oneshot.cocci: Improve the generated commit log
2015-05-25 6:30 ` Valentin Rothberg
@ 2015-05-25 8:24 ` Michal Marek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Marek @ 2015-05-25 8:24 UTC (permalink / raw)
To: cocci
Dne 25.5.2015 v 14:30 Valentin Rothberg napsal(a):
> On Mon, May 25, 2015 at 8:21 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> Valentin? (It's his semantic patch)
>>
>> julia
>>
>> On Sun, 24 May 2015, Fabio Estevam wrote:
>>
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> Improve the commit log of the generated patch by mentioning the commit
>>> log that makes threaded IRQs without a primary handler to be requested
>>> with the IRQF_ONESHOT flag.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked- by: Valentin Rothberg <valentinrothberg@gmail.com>
Thanks, applied to kbuild.git#misc.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-25 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-24 20:45 [Cocci] [PATCH] coccinelle: irqf_oneshot.cocci: Improve the generated commit log Fabio Estevam
2015-05-25 6:21 ` Julia Lawall
2015-05-25 6:30 ` Valentin Rothberg
2015-05-25 8:24 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.