[Devel] [PATCH] ACPICA: Add MADT generic distributor version values for ACPI 6.0

[Devel] [PATCH] ACPICA: Add MADT generic distributor version values for ACPI 6.0

[Hanjun Guo]

[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]

ACPI 6.0 specified MADT generic distributor version values, but
the detail definition is missing, add its support in this patch.

Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org>
---
Hi Bob, Lv,

As discussed with Lv on linux-acpi maillist, I prepared this
patch for review.

Please treat this patch as a fix for next ACPICA version and
linux kernel 4.2 material, because we still can not
use the newest ACPICA for linux when this enum is missing,
any comments are welcomed.

Thanks
Hanjun

 source/include/actbl1.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/source/include/actbl1.h b/source/include/actbl1.h
index 1c508a0..0235543 100644
--- a/source/include/actbl1.h
+++ b/source/include/actbl1.h
@@ -1050,6 +1050,18 @@ typedef struct acpi_madt_generic_distributor
 
 } ACPI_MADT_GENERIC_DISTRIBUTOR;
 
+/* Values for Version in Generic Distributor  (ACPI 6.0) */
+
+enum AcpiMadtGicVersionType
+{
+    ACPI_MADT_GIC_VER_UNKNOWN    = 0,
+    ACPI_MADT_GIC_VER_V1         = 1,
+    ACPI_MADT_GIC_VER_V2         = 2,
+    ACPI_MADT_GIC_VER_V3         = 3,
+    ACPI_MADT_GIC_VER_V4         = 4,
+    ACPI_MADT_GIC_VER_RESERVED   = 5    /* 5 and greater are reserved */
+};
+
 
 /* 13: Generic MSI Frame (ACPI 5.1) */
 
-- 
1.9.1

Re: [Devel] [PATCH] ACPICA: Add MADT generic distributor version values for ACPI 6.0

[Hanjun Guo]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

On 2015年05月25日 17:24, Hanjun Guo wrote:
> ACPI 6.0 specified MADT generic distributor version values, but
> the detail definition is missing, add its support in this patch.
>
> Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org>
> ---
> Hi Bob, Lv,
>
> As discussed with Lv on linux-acpi maillist, I prepared this
> patch for review.
>
> Please treat this patch as a fix for next ACPICA version and
> linux kernel 4.2 material, because we still can not
> use the newest ACPICA for linux when this enum is missing,

s/for linux/ for ARM ACPI linux, sorry.

Hanjun

> any comments are welcomed.
>
> Thanks
> Hanjun
>
>   source/include/actbl1.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/source/include/actbl1.h b/source/include/actbl1.h
> index 1c508a0..0235543 100644
> --- a/source/include/actbl1.h
> +++ b/source/include/actbl1.h
> @@ -1050,6 +1050,18 @@ typedef struct acpi_madt_generic_distributor
>
>   } ACPI_MADT_GENERIC_DISTRIBUTOR;
>
> +/* Values for Version in Generic Distributor  (ACPI 6.0) */
> +
> +enum AcpiMadtGicVersionType
> +{
> +    ACPI_MADT_GIC_VER_UNKNOWN    = 0,
> +    ACPI_MADT_GIC_VER_V1         = 1,
> +    ACPI_MADT_GIC_VER_V2         = 2,
> +    ACPI_MADT_GIC_VER_V3         = 3,
> +    ACPI_MADT_GIC_VER_V4         = 4,
> +    ACPI_MADT_GIC_VER_RESERVED   = 5    /* 5 and greater are reserved */
> +};
> +
>
>   /* 13: Generic MSI Frame (ACPI 5.1) */
>
>

[Devel] [PATCH] ACPICA: Add MADT generic distributor version values for ACPI 6.0

[Hanjun Guo]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

ACPI 6.0 specified MADT generic distributor version values, but
the detail definition is missing in ACPICA version 20150515, add
its support in this patch.

Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org>
---

This is the linux version of GIC version patch, please
help to handle it, thanks!

 include/acpi/actbl1.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index 06b61f0..a53530d1 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -835,6 +835,17 @@ struct acpi_madt_generic_distributor {
 	u8 reserved2[3];	/* reserved - must be zero */
 };
 
+/* Values for version in Generic Distributor  (ACPI 6.0) */
+
+enum acpi_madt_gic_version_type {
+	ACPI_MADT_GIC_VER_UNKNOWN	= 0,
+	ACPI_MADT_GIC_VER_V1		= 1,
+	ACPI_MADT_GIC_VER_V2		= 2,
+	ACPI_MADT_GIC_VER_V3		= 3,
+	ACPI_MADT_GIC_VER_V4		= 4,
+	ACPI_MADT_GIC_VER_RESERVED	= 5	/* 5 and greater are reserved */
+};
+
 /* 13: Generic MSI Frame (ACPI 5.1) */
 
 struct acpi_madt_generic_msi_frame {
-- 
1.9.1

Re: [Devel] [PATCH] ACPICA: Add MADT generic distributor version values for ACPI 6.0

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

Usually, we ACPICA just #defines the individual values so that it is very easy to see the values at a glance. We only enum internal things.



> -----Original Message-----
> From: Hanjun Guo [mailto:hanjun.guo(a)linaro.org]
> Sent: Friday, May 29, 2015 12:46 AM
> To: Zheng, Lv
> Cc: Moore, Robert; Rafael J. Wysocki; Al Stone; devel(a)acpica.org; linux-
> acpi(a)vger.kernel.org; Hanjun Guo
> Subject: [PATCH] ACPICA: Add MADT generic distributor version values for
> ACPI 6.0
> 
> ACPI 6.0 specified MADT generic distributor version values, but the detail
> definition is missing in ACPICA version 20150515, add its support in this
> patch.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org>
> ---
> 
> This is the linux version of GIC version patch, please help to handle it,
> thanks!
> 
>  include/acpi/actbl1.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> 06b61f0..a53530d1 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -835,6 +835,17 @@ struct acpi_madt_generic_distributor {
>  	u8 reserved2[3];	/* reserved - must be zero */
>  };
> 
> +/* Values for version in Generic Distributor  (ACPI 6.0) */
> +
> +enum acpi_madt_gic_version_type {
> +	ACPI_MADT_GIC_VER_UNKNOWN	= 0,
> +	ACPI_MADT_GIC_VER_V1		= 1,
> +	ACPI_MADT_GIC_VER_V2		= 2,
> +	ACPI_MADT_GIC_VER_V3		= 3,
> +	ACPI_MADT_GIC_VER_V4		= 4,
> +	ACPI_MADT_GIC_VER_RESERVED	= 5	/* 5 and greater are reserved */
> +};
> +
>  /* 13: Generic MSI Frame (ACPI 5.1) */
> 
>  struct acpi_madt_generic_msi_frame {
> --
> 1.9.1

Re: [Devel] [PATCH] ACPICA: Add MADT generic distributor version values for ACPI 6.0

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 2325 bytes --]

Actually, that is fine the way it is. I'll integrate it today.


> -----Original Message-----
> From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Moore, Robert
> Sent: Friday, May 29, 2015 5:55 AM
> To: Hanjun Guo; Zheng, Lv
> Cc: linux-acpi(a)vger.kernel.org; Rafael J. Wysocki; Al Stone;
> devel(a)acpica.org
> Subject: Re: [Devel] [PATCH] ACPICA: Add MADT generic distributor version
> values for ACPI 6.0
> 
> Usually, we ACPICA just #defines the individual values so that it is very
> easy to see the values at a glance. We only enum internal things.
> 
> 
> 
> > -----Original Message-----
> > From: Hanjun Guo [mailto:hanjun.guo(a)linaro.org]
> > Sent: Friday, May 29, 2015 12:46 AM
> > To: Zheng, Lv
> > Cc: Moore, Robert; Rafael J. Wysocki; Al Stone; devel(a)acpica.org;
> > linux- acpi(a)vger.kernel.org; Hanjun Guo
> > Subject: [PATCH] ACPICA: Add MADT generic distributor version values
> > for ACPI 6.0
> >
> > ACPI 6.0 specified MADT generic distributor version values, but the
> > detail definition is missing in ACPICA version 20150515, add its
> > support in this patch.
> >
> > Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org>
> > ---
> >
> > This is the linux version of GIC version patch, please help to handle
> > it, thanks!
> >
> >  include/acpi/actbl1.h | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > 06b61f0..a53530d1 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -835,6 +835,17 @@ struct acpi_madt_generic_distributor {
> >  	u8 reserved2[3];	/* reserved - must be zero */
> >  };
> >
> > +/* Values for version in Generic Distributor  (ACPI 6.0) */
> > +
> > +enum acpi_madt_gic_version_type {
> > +	ACPI_MADT_GIC_VER_UNKNOWN	= 0,
> > +	ACPI_MADT_GIC_VER_V1		= 1,
> > +	ACPI_MADT_GIC_VER_V2		= 2,
> > +	ACPI_MADT_GIC_VER_V3		= 3,
> > +	ACPI_MADT_GIC_VER_V4		= 4,
> > +	ACPI_MADT_GIC_VER_RESERVED	= 5	/* 5 and greater are reserved */
> > +};
> > +
> >  /* 13: Generic MSI Frame (ACPI 5.1) */
> >
> >  struct acpi_madt_generic_msi_frame {
> > --
> > 1.9.1
> 
> _______________________________________________
> Devel mailing list
> Devel(a)acpica.org
> https://lists.acpica.org/mailman/listinfo/devel