* [Qemu-trivial] [PATCH] vl: fix memory leak spotted by valgrind
@ 2015-05-25 6:47 ` Shannon Zhao
0 siblings, 0 replies; 6+ messages in thread
From: Shannon Zhao @ 2015-05-25 6:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, shannon.zhao
From: Shannon Zhao <shannon.zhao@linaro.org>
valgrind complains about:
==9276== 13 bytes in 1 blocks are definitely lost in loss record 1,046 of 3,673
==9276== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==9276== by 0x2EAFBB: malloc_and_trace (vl.c:2556)
==9276== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
==9276== by 0x4A28BD: addr_to_string (vnc.c:123)
==9276== by 0x4A29AD: vnc_socket_local_addr (vnc.c:139)
==9276== by 0x4A9AFE: vnc_display_local_addr (vnc.c:3240)
==9276== by 0x2EF4FE: main (vl.c:4321)
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
vl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 74c2681..9539e7b 100644
--- a/vl.c
+++ b/vl.c
@@ -4295,8 +4295,9 @@ int main(int argc, char **argv, char **envp)
/* init remote displays */
qemu_opts_foreach(qemu_find_opts("vnc"), vnc_init_func, NULL, 0);
if (show_vnc_port) {
- printf("VNC server running on `%s'\n",
- vnc_display_local_addr("default"));
+ char *ret = vnc_display_local_addr("default");
+ printf("VNC server running on `%s'\n", ret);
+ g_free(ret);
}
#endif
#ifdef CONFIG_SPICE
--
2.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] vl: fix memory leak spotted by valgrind
@ 2015-05-25 6:47 ` Shannon Zhao
0 siblings, 0 replies; 6+ messages in thread
From: Shannon Zhao @ 2015-05-25 6:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, shannon.zhao
From: Shannon Zhao <shannon.zhao@linaro.org>
valgrind complains about:
==9276== 13 bytes in 1 blocks are definitely lost in loss record 1,046 of 3,673
==9276== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==9276== by 0x2EAFBB: malloc_and_trace (vl.c:2556)
==9276== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
==9276== by 0x4A28BD: addr_to_string (vnc.c:123)
==9276== by 0x4A29AD: vnc_socket_local_addr (vnc.c:139)
==9276== by 0x4A9AFE: vnc_display_local_addr (vnc.c:3240)
==9276== by 0x2EF4FE: main (vl.c:4321)
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
vl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 74c2681..9539e7b 100644
--- a/vl.c
+++ b/vl.c
@@ -4295,8 +4295,9 @@ int main(int argc, char **argv, char **envp)
/* init remote displays */
qemu_opts_foreach(qemu_find_opts("vnc"), vnc_init_func, NULL, 0);
if (show_vnc_port) {
- printf("VNC server running on `%s'\n",
- vnc_display_local_addr("default"));
+ char *ret = vnc_display_local_addr("default");
+ printf("VNC server running on `%s'\n", ret);
+ g_free(ret);
}
#endif
#ifdef CONFIG_SPICE
--
2.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] vl: fix memory leak spotted by valgrind
2015-05-25 6:47 ` [Qemu-devel] " Shannon Zhao
@ 2015-05-25 13:08 ` Paolo Bonzini
-1 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-05-25 13:08 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel; +Cc: qemu-trivial, shannon.zhao
On 25/05/2015 08:47, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> valgrind complains about:
> ==9276== 13 bytes in 1 blocks are definitely lost in loss record 1,046 of 3,673
> ==9276== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==9276== by 0x2EAFBB: malloc_and_trace (vl.c:2556)
> ==9276== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
> ==9276== by 0x4A28BD: addr_to_string (vnc.c:123)
> ==9276== by 0x4A29AD: vnc_socket_local_addr (vnc.c:139)
> ==9276== by 0x4A9AFE: vnc_display_local_addr (vnc.c:3240)
> ==9276== by 0x2EF4FE: main (vl.c:4321)
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> vl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 74c2681..9539e7b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4295,8 +4295,9 @@ int main(int argc, char **argv, char **envp)
> /* init remote displays */
> qemu_opts_foreach(qemu_find_opts("vnc"), vnc_init_func, NULL, 0);
> if (show_vnc_port) {
> - printf("VNC server running on `%s'\n",
> - vnc_display_local_addr("default"));
> + char *ret = vnc_display_local_addr("default");
> + printf("VNC server running on `%s'\n", ret);
> + g_free(ret);
> }
> #endif
> #ifdef CONFIG_SPICE
>
Thanks, queued for 2.4.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] vl: fix memory leak spotted by valgrind
@ 2015-05-25 13:08 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-05-25 13:08 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel; +Cc: qemu-trivial, shannon.zhao
On 25/05/2015 08:47, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> valgrind complains about:
> ==9276== 13 bytes in 1 blocks are definitely lost in loss record 1,046 of 3,673
> ==9276== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==9276== by 0x2EAFBB: malloc_and_trace (vl.c:2556)
> ==9276== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
> ==9276== by 0x4A28BD: addr_to_string (vnc.c:123)
> ==9276== by 0x4A29AD: vnc_socket_local_addr (vnc.c:139)
> ==9276== by 0x4A9AFE: vnc_display_local_addr (vnc.c:3240)
> ==9276== by 0x2EF4FE: main (vl.c:4321)
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> vl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 74c2681..9539e7b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4295,8 +4295,9 @@ int main(int argc, char **argv, char **envp)
> /* init remote displays */
> qemu_opts_foreach(qemu_find_opts("vnc"), vnc_init_func, NULL, 0);
> if (show_vnc_port) {
> - printf("VNC server running on `%s'\n",
> - vnc_display_local_addr("default"));
> + char *ret = vnc_display_local_addr("default");
> + printf("VNC server running on `%s'\n", ret);
> + g_free(ret);
> }
> #endif
> #ifdef CONFIG_SPICE
>
Thanks, queued for 2.4.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] vl: fix memory leak spotted by valgrind
2015-05-25 6:47 ` [Qemu-devel] " Shannon Zhao
@ 2015-05-28 12:05 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-05-28 12:05 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel; +Cc: qemu-trivial, shannon.zhao
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-28 12:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 6:47 [Qemu-trivial] [PATCH] vl: fix memory leak spotted by valgrind Shannon Zhao
2015-05-25 6:47 ` [Qemu-devel] " Shannon Zhao
2015-05-25 13:08 ` [Qemu-trivial] " Paolo Bonzini
2015-05-25 13:08 ` [Qemu-devel] " Paolo Bonzini
2015-05-28 12:05 ` [Qemu-trivial] " Michael Tokarev
2015-05-28 12:05 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.