All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Bin <huawei.libin@huawei.com>
To: Jiri Kosina <jkosina@suse.cz>, Nicholas Mc Guire <hofrat@osadl.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
	Seth Jennings <sjenning@redhat.com>,
	Vojtech Pavlik <vojtech@suse.cz>, <live-patching@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, xiexiuqi <xiexiuqi@huawei.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Libin <huawei.libin@huawei.com>
Subject: [PATCH] livepatch: match function return value type with prototype
Date: Tue, 26 May 2015 10:44:56 +0800	[thread overview]
Message-ID: <5563DE28.4070100@huawei.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1505112345430.8186@pobox.suse.cz>

The klp_is_module return type should be boolean.

Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
 kernel/livepatch/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 284e269..30e9339 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -78,7 +78,7 @@ static struct klp_ops *klp_find_ops(unsigned long old_addr)

 static bool klp_is_module(struct klp_object *obj)
 {
-	return obj->name;
+	return !!obj->name;
 }

 static bool klp_is_object_loaded(struct klp_object *obj)
-- 
1.7.1



  parent reply	other threads:[~2015-05-26  2:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  5:52 [PATCH] livepatch: match return value to function signature Nicholas Mc Guire
2015-05-11  8:24 ` Jiri Slaby
2015-05-27  6:56   ` Nicholas Mc Guire
2015-05-27  7:14     ` Jiri Slaby
2015-05-27  7:21       ` Nicholas Mc Guire
2015-05-11 16:42 ` Josh Poimboeuf
2015-05-11 21:46 ` Jiri Kosina
2015-05-26  2:41   ` livepatch: match function return value type with prototype Li Bin
2015-05-26  2:44   ` Li Bin [this message]
2015-05-26  4:46     ` [PATCH] " Minfei Huang
2015-05-26  7:32       ` Jiri Slaby
2015-05-28  5:59         ` Li Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5563DE28.4070100@huawei.com \
    --to=huawei.libin@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=hofrat@osadl.org \
    --cc=jkosina@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=sjenning@redhat.com \
    --cc=vojtech@suse.cz \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.