From: Jiri Slaby <jslaby@suse.cz>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: match return value to function signature
Date: Wed, 27 May 2015 09:14:04 +0200 [thread overview]
Message-ID: <55656EBC.4030200@suse.cz> (raw)
In-Reply-To: <20150527065605.GA11782@opentech.at>
On 05/27/2015, 08:56 AM, Nicholas Mc Guire wrote:
> On Mon, 11 May 2015, Jiri Slaby wrote:
>
>> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote:
>>> klp_initialized() should return bool but is actually returning
>>> struct kobject * - convert it to a boolean explicitly.
>>>
>>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>>
>> Reviewed-by: Jiri Slaby <jslaby@suse.cz>
>>
> sorry for the noise - discussions about a similar "cleanup" in RCU
> resulted Joe Perches <joe@perches.com> clarifying the matter - this
> explicit conversion makes static code checkers happy but is not
> needed for gcc (or C for that mater) - see
> http://lkml.org/lkml/2015/5/24/47
> and ISO/IEC 9899:1999 (c99) 6.8.6.4 subclause 3)
Oh yes and I seem to be inconsistent with replies:
https://lkml.org/lkml/2015/5/26/90
> hofrat
You? Nuremberg, 2010, Stanse?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2015-05-27 7:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 5:52 [PATCH] livepatch: match return value to function signature Nicholas Mc Guire
2015-05-11 8:24 ` Jiri Slaby
2015-05-27 6:56 ` Nicholas Mc Guire
2015-05-27 7:14 ` Jiri Slaby [this message]
2015-05-27 7:21 ` Nicholas Mc Guire
2015-05-11 16:42 ` Josh Poimboeuf
2015-05-11 21:46 ` Jiri Kosina
2015-05-26 2:41 ` livepatch: match function return value type with prototype Li Bin
2015-05-26 2:44 ` [PATCH] " Li Bin
2015-05-26 4:46 ` Minfei Huang
2015-05-26 7:32 ` Jiri Slaby
2015-05-28 5:59 ` Li Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55656EBC.4030200@suse.cz \
--to=jslaby@suse.cz \
--cc=der.herr@hofr.at \
--cc=hofrat@osadl.org \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.