From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode_var()
Date: Tue, 26 May 2015 08:32:52 +0000 [thread overview]
Message-ID: <55642FB4.3060902@ti.com> (raw)
In-Reply-To: <1431970264-16195-1-git-send-email-fabf@skynet.be>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On 18/05/15 20:31, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/video/fbdev/matrox/matroxfb_base.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
> index 62539ca..2ba4e54 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_base.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c
> @@ -591,12 +591,8 @@ static int matroxfb_decode_var(const struct matrox_fb_info *minfo,
> unsigned int max_yres;
>
> while (m1) {
> - int t;
> -
> while (m2 >= m1) m2 -= m1;
> - t = m1;
> - m1 = m2;
> - m2 = t;
> + swap(m1, m2);
> }
> m2 = linelen * PAGE_SIZE / m2;
> *ydstorg = m2 = 0x400000 % m2;
>
Thanks, I've queued this and the two other swap() patches for 4.2.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Fabian Frederick <fabf@skynet.be>, <linux-kernel@vger.kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode_var()
Date: Tue, 26 May 2015 11:32:52 +0300 [thread overview]
Message-ID: <55642FB4.3060902@ti.com> (raw)
In-Reply-To: <1431970264-16195-1-git-send-email-fabf@skynet.be>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On 18/05/15 20:31, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/video/fbdev/matrox/matroxfb_base.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
> index 62539ca..2ba4e54 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_base.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c
> @@ -591,12 +591,8 @@ static int matroxfb_decode_var(const struct matrox_fb_info *minfo,
> unsigned int max_yres;
>
> while (m1) {
> - int t;
> -
> while (m2 >= m1) m2 -= m1;
> - t = m1;
> - m1 = m2;
> - m2 = t;
> + swap(m1, m2);
> }
> m2 = linelen * PAGE_SIZE / m2;
> *ydstorg = m2 = 0x400000 % m2;
>
Thanks, I've queued this and the two other swap() patches for 4.2.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-26 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:31 [PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode_var() Fabian Frederick
2015-05-18 17:31 ` Fabian Frederick
2015-05-26 8:32 ` Tomi Valkeinen [this message]
2015-05-26 8:32 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55642FB4.3060902@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=fabf@skynet.be \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.