From: Arnd Bergmann <arnd@arndb.de>
To: Eric Auger <eric.auger@linaro.org>
Cc: eric.auger@st.com, alex.williamson@redhat.com,
b.reynal@virtualopensystems.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
christoffer.dall@linaro.org, linux-kernel@vger.kernel.org,
patches@linaro.org
Subject: Re: [PATCH 0/4] VFIO platform reset module rework
Date: Mon, 19 Oct 2015 15:08:50 +0200 [thread overview]
Message-ID: <5564303.6Ntpr32PW1@wuerfel> (raw)
In-Reply-To: <1445184015-24414-1-git-send-email-eric.auger@linaro.org>
On Sunday 18 October 2015 18:00:11 Eric Auger wrote:
> This series fixes the current implementation by getting rid of the
> usage of __symbol_get which caused a compilation issue with
> CONFIG_MODULES disabled. On top of this, the usage of MODULE_ALIAS makes
> possible to add a new reset module without being obliged to update the
> framework. The new implementation relies on the reset module registering
> its reset function to the vfio-platform driver.
>
> The series is available at
>
> https://git.linaro.org/people/eric.auger/linux.git/shortlog/refs/heads/v4.3-rc5-rework-xgbe-v2
>
>
Looks good for the most part, just a few comments on coding style
for patches 1 and 2.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] VFIO platform reset module rework
Date: Mon, 19 Oct 2015 15:08:50 +0200 [thread overview]
Message-ID: <5564303.6Ntpr32PW1@wuerfel> (raw)
In-Reply-To: <1445184015-24414-1-git-send-email-eric.auger@linaro.org>
On Sunday 18 October 2015 18:00:11 Eric Auger wrote:
> This series fixes the current implementation by getting rid of the
> usage of __symbol_get which caused a compilation issue with
> CONFIG_MODULES disabled. On top of this, the usage of MODULE_ALIAS makes
> possible to add a new reset module without being obliged to update the
> framework. The new implementation relies on the reset module registering
> its reset function to the vfio-platform driver.
>
> The series is available at
>
> https://git.linaro.org/people/eric.auger/linux.git/shortlog/refs/heads/v4.3-rc5-rework-xgbe-v2
>
>
Looks good for the most part, just a few comments on coding style
for patches 1 and 2.
Arnd
next prev parent reply other threads:[~2015-10-19 13:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 16:00 [PATCH 0/4] VFIO platform reset module rework Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` [PATCH 1/4] vfio: platform: add capability to register a reset function Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-19 13:08 ` Arnd Bergmann
2015-10-19 13:08 ` Arnd Bergmann
2015-10-19 13:08 ` Arnd Bergmann
2015-10-19 19:45 ` Alex Williamson
2015-10-19 19:45 ` Alex Williamson
2015-10-20 17:48 ` Eric Auger
2015-10-20 17:48 ` Eric Auger
2015-10-18 16:00 ` [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-19 13:04 ` Arnd Bergmann
2015-10-19 13:04 ` Arnd Bergmann
2015-10-19 13:04 ` Arnd Bergmann
2015-10-19 13:17 ` Eric Auger
2015-10-19 13:17 ` Eric Auger
2015-10-19 13:25 ` Arnd Bergmann
2015-10-19 13:25 ` Arnd Bergmann
2015-10-19 13:34 ` Eric Auger
2015-10-19 13:34 ` Eric Auger
2015-10-18 16:00 ` [PATCH 3/4] vfio: platform: add compat in vfio_platform_device Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` [PATCH 4/4] vfio: platform: use list of registered reset function Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-18 16:00 ` Eric Auger
2015-10-19 13:08 ` Arnd Bergmann [this message]
2015-10-19 13:08 ` [PATCH 0/4] VFIO platform reset module rework Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5564303.6Ntpr32PW1@wuerfel \
--to=arnd@arndb.de \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.