All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Wu Fengguang <fengguang.wu@intel.com>, Christoph Hellwig <hch@lst.de>
Cc: kbuild-all@01.org, Nicholas Bellinger <nab@linux-iscsi.org>,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH target] target: se_dev_check_wce() can be static
Date: Tue, 26 May 2015 11:02:08 +0200	[thread overview]
Message-ID: <55643690.8040309@sandisk.com> (raw)
In-Reply-To: <20150526081320.GA111779@lkp-sb04>

On 05/26/15 10:13, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   target_core_device.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2321884..1d309ad 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -649,7 +649,7 @@ static u32 se_dev_align_max_sectors(u32 max_sectors, u32 block_size)
>   	return aligned_max_sectors;
>   }
>
> -bool se_dev_check_wce(struct se_device *dev)
> +static bool se_dev_check_wce(struct se_device *dev)
>   {
>   	bool wce = false;
>

Since patch "target: fix DPO and FUA bit checks" removed the last user 
of this function, please remove this function completely instead of 
declaring it static.

Thanks,

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Wu Fengguang <fengguang.wu@intel.com>, Christoph Hellwig <hch@lst.de>
Cc: <kbuild-all@01.org>, Nicholas Bellinger <nab@linux-iscsi.org>,
	<linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH target] target: se_dev_check_wce() can be static
Date: Tue, 26 May 2015 11:02:08 +0200	[thread overview]
Message-ID: <55643690.8040309@sandisk.com> (raw)
In-Reply-To: <20150526081320.GA111779@lkp-sb04>

On 05/26/15 10:13, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   target_core_device.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2321884..1d309ad 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -649,7 +649,7 @@ static u32 se_dev_align_max_sectors(u32 max_sectors, u32 block_size)
>   	return aligned_max_sectors;
>   }
>
> -bool se_dev_check_wce(struct se_device *dev)
> +static bool se_dev_check_wce(struct se_device *dev)
>   {
>   	bool wce = false;
>

Since patch "target: fix DPO and FUA bit checks" removed the last user 
of this function, please remove this function completely instead of 
declaring it static.

Thanks,

Bart.

  reply	other threads:[~2015-05-26  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26  8:13 [target:for-next 53/60] drivers/target/target_core_device.c:652:6: sparse: symbol 'se_dev_check_wce' was not declared. Should it be static? kbuild test robot
2015-05-26  8:13 ` [PATCH target] target: se_dev_check_wce() can be static kbuild test robot
2015-05-26  9:02   ` Bart Van Assche [this message]
2015-05-26  9:02     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55643690.8040309@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=fengguang.wu@intel.com \
    --cc=hch@lst.de \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.