From: Mike Kravetz <mike.kravetz@oracle.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/2] mm/hugetlb: compute/return the number of regions added by region_add()
Date: Tue, 26 May 2015 15:59:26 -0700 [thread overview]
Message-ID: <5564FACE.9070204@oracle.com> (raw)
In-Reply-To: <1432585785.2185.59.camel@stgolabs.net>
On 05/25/2015 01:29 PM, Davidlohr Bueso wrote:
> On Fri, 2015-05-22 at 20:55 -0700, Mike Kravetz wrote:
>> +/*
>> + * Add the huge page range represented by indicies f (from)
>> + * and t (to) to the reserve map. Existing regions will be
>
> How about simply renaming those parameters to from and to across the
> entire hugetlb code.
>
> Thanks,
> Davidlohr
After adding the notation suggested by Naoya Horiguchi and cleaning
up that specific comment, I think using f and t is OK. See the
documentation only patch:
[PATCH] mm/hugetlb: document the reserve map/region tracking routines
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/2] mm/hugetlb: compute/return the number of regions added by region_add()
Date: Tue, 26 May 2015 15:59:26 -0700 [thread overview]
Message-ID: <5564FACE.9070204@oracle.com> (raw)
In-Reply-To: <1432585785.2185.59.camel@stgolabs.net>
On 05/25/2015 01:29 PM, Davidlohr Bueso wrote:
> On Fri, 2015-05-22 at 20:55 -0700, Mike Kravetz wrote:
>> +/*
>> + * Add the huge page range represented by indicies f (from)
>> + * and t (to) to the reserve map. Existing regions will be
>
> How about simply renaming those parameters to from and to across the
> entire hugetlb code.
>
> Thanks,
> Davidlohr
After adding the notation suggested by Naoya Horiguchi and cleaning
up that specific comment, I think using f and t is OK. See the
documentation only patch:
[PATCH] mm/hugetlb: document the reserve map/region tracking routines
--
Mike Kravetz
next prev parent reply other threads:[~2015-05-26 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 3:55 [PATCH v2 0/2] alloc_huge_page/hugetlb_reserve_pages race Mike Kravetz
2015-05-23 3:55 ` Mike Kravetz
2015-05-23 3:55 ` [PATCH v2 1/2] mm/hugetlb: compute/return the number of regions added by region_add() Mike Kravetz
2015-05-23 3:55 ` Mike Kravetz
2015-05-25 6:19 ` Naoya Horiguchi
2015-05-25 6:19 ` Naoya Horiguchi
2015-05-26 16:30 ` Mike Kravetz
2015-05-26 16:30 ` Mike Kravetz
2015-05-25 20:29 ` Davidlohr Bueso
2015-05-25 20:29 ` Davidlohr Bueso
2015-05-26 22:59 ` Mike Kravetz [this message]
2015-05-26 22:59 ` Mike Kravetz
2015-05-23 3:55 ` [PATCH v2 2/2] mm/hugetlb: handle races in alloc_huge_page and hugetlb_reserve_pages Mike Kravetz
2015-05-23 3:55 ` Mike Kravetz
2015-05-25 19:58 ` [PATCH v2 0/2] alloc_huge_page/hugetlb_reserve_pages race Davidlohr Bueso
2015-05-25 19:58 ` Davidlohr Bueso
2015-05-26 17:10 ` Mike Kravetz
2015-05-26 17:10 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5564FACE.9070204@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.