From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH] mm/hugetlb: document the reserve map/region tracking routines
Date: Tue, 26 May 2015 20:30:52 -0700 [thread overview]
Message-ID: <55653A6C.3060707@oracle.com> (raw)
In-Reply-To: <20150526160900.0c0868b73e40995d3d65c616@linux-foundation.org>
On 05/26/2015 04:09 PM, Andrew Morton wrote:
> On Tue, 26 May 2015 14:27:10 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> This is a documentation only patch and does not modify any code.
>> Descriptions of the routines used for reserve map/region tracking
>> are added.
>
> Confused. This adds comments which are similar to the ones which were
> added by
> mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v2.patch
> and
> mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v2.patch.
> But the comments are a bit different. And this patch madly conflicts
> with the two abovementioned patches.
>
> Maybe the thing to do is to start again, with a three-patch series:
>
> mm-hugetlb-document-the-reserve-map-region-tracking-routines.patch
> mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v3.patch
> mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v3.patch
>
> while resolving the differences in the new code comments?
>
Sorry for the confusion. Naoya and Davidlohr suggested changes to
the documentation and code. One suggestion was to create a separate
documentation only patch.
I will create a new series as you suggest above.
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH] mm/hugetlb: document the reserve map/region tracking routines
Date: Tue, 26 May 2015 20:30:52 -0700 [thread overview]
Message-ID: <55653A6C.3060707@oracle.com> (raw)
In-Reply-To: <20150526160900.0c0868b73e40995d3d65c616@linux-foundation.org>
On 05/26/2015 04:09 PM, Andrew Morton wrote:
> On Tue, 26 May 2015 14:27:10 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> This is a documentation only patch and does not modify any code.
>> Descriptions of the routines used for reserve map/region tracking
>> are added.
>
> Confused. This adds comments which are similar to the ones which were
> added by
> mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v2.patch
> and
> mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v2.patch.
> But the comments are a bit different. And this patch madly conflicts
> with the two abovementioned patches.
>
> Maybe the thing to do is to start again, with a three-patch series:
>
> mm-hugetlb-document-the-reserve-map-region-tracking-routines.patch
> mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v3.patch
> mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v3.patch
>
> while resolving the differences in the new code comments?
>
Sorry for the confusion. Naoya and Davidlohr suggested changes to
the documentation and code. One suggestion was to create a separate
documentation only patch.
I will create a new series as you suggest above.
--
Mike Kravetz
next prev parent reply other threads:[~2015-05-27 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 21:27 [PATCH] mm/hugetlb: document the reserve map/region tracking routines Mike Kravetz
2015-05-26 21:27 ` Mike Kravetz
2015-05-26 23:09 ` Andrew Morton
2015-05-26 23:09 ` Andrew Morton
2015-05-27 3:30 ` Mike Kravetz [this message]
2015-05-27 3:30 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55653A6C.3060707@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.