From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, boby.chen@huawei.com
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: question on "xen-blkback: enlarge the array size of blkback name"
Date: Wed, 27 May 2015 10:28:40 +0100 [thread overview]
Message-ID: <55658E48.5060409@citrix.com> (raw)
In-Reply-To: <5565A0C5020000780007E1F1@mail.emea.novell.com>
El 27/05/15 a les 9.47, Jan Beulich ha escrit:
> Hello,
>
> looking at this once again now that it's upstream, I still can't see what
> this is good for: The only use the produced string has is to be passed
> to kthread_run(), i.e. ultimately to be stored in a task's ->comm. That,
> however, continues to be limited to 16 characters, so
> blkback.domid.xvd[a-z] being up to 18 characters I don't understand
> how the change results in the full name being shown. What am I
> missing?
Right, I didn't realize there was a length limitation in task_struct.
How did you manage to get it working Chentao?
> Why aren't you instead shortening the string to e.g.
> blkbk.domid.xvd[a-z] (which still is 16 characters, i.e. the last
> character would still be chopped off for 5 digit domain IDs; perhaps
> the first dot should then also be dropped).
That sounds right.
Roger.
next prev parent reply other threads:[~2015-05-27 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 8:47 question on "xen-blkback: enlarge the array size of blkback name" Jan Beulich
2015-05-27 9:28 ` Roger Pau Monné [this message]
2015-05-27 9:57 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55658E48.5060409@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=boby.chen@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.