All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Zhao <shannon.zhao@linaro.org>
To: Eric Auger <eric.auger@linaro.org>,
	eric.auger@st.com, qemu-devel@nongnu.org,
	peter.maydell@linaro.org
Cc: patches@linaro.org, agraf@suse.de, alex.williamson@redhat.com,
	pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu,
	christoffer.dall@linaro.org
Subject: Re: [RESEND PATCH v12 4/4] hw/arm/virt: change indentation in a15memmap
Date: Wed, 27 May 2015 22:05:50 +0800	[thread overview]
Message-ID: <5565CF3E.7040100@linaro.org> (raw)
In-Reply-To: <1432716470-2096-5-git-send-email-eric.auger@linaro.org>



On 2015年05月27日 16:47, Eric Auger wrote:
> Re-indent in a15memmap after VIRT_PLATFORM_BUS introduction
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
>
> v11 -> v12:
> - Add Alex R-b
> ---
>   hw/arm/virt.c | 26 +++++++++++++-------------
>   1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 199d031..6c1ec58 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -128,26 +128,26 @@ typedef struct {
>    */
>   static const MemMapEntry a15memmap[] = {
>       /* Space up to 0x8000000 is reserved for a boot ROM */
> -    [VIRT_FLASH] =      {          0, 0x08000000 },
> -    [VIRT_CPUPERIPHS] = { 0x08000000, 0x00020000 },
> +    [VIRT_FLASH] =          {          0, 0x08000000 },
> +    [VIRT_CPUPERIPHS] =     { 0x08000000, 0x00020000 },
>       /* GIC distributor and CPU interfaces sit inside the CPU peripheral space */
> -    [VIRT_GIC_DIST] =   { 0x08000000, 0x00010000 },
> -    [VIRT_GIC_CPU] =    { 0x08010000, 0x00010000 },
> -    [VIRT_UART] =       { 0x09000000, 0x00001000 },
> -    [VIRT_RTC] =        { 0x09010000, 0x00001000 },
> -    [VIRT_FW_CFG] =     { 0x09020000, 0x0000000a },
> -    [VIRT_MMIO] =       { 0x0a000000, 0x00000200 },
> +    [VIRT_GIC_DIST] =       { 0x08000000, 0x00010000 },
> +    [VIRT_GIC_CPU] =        { 0x08010000, 0x00010000 },
> +    [VIRT_UART] =           { 0x09000000, 0x00001000 },
> +    [VIRT_RTC] =            { 0x09010000, 0x00001000 },
> +    [VIRT_FW_CFG] =         { 0x09020000, 0x0000000a },
> +    [VIRT_MMIO] =           { 0x0a000000, 0x00000200 },
>       /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size */
>       [VIRT_PLATFORM_BUS] =   { 0x0c000000, 0x02000000 },
>       /*
>        * PCIE verbose map:
>        *
> -     * MMIO window      { 0x10000000, 0x2eff0000 },
> -     * PIO window       { 0x3eff0000, 0x00010000 },
> -     * ECAM             { 0x3f000000, 0x01000000 },
> +     * MMIO window          { 0x10000000, 0x2eff0000 },
> +     * PIO window           { 0x3eff0000, 0x00010000 },
> +     * ECAM                 { 0x3f000000, 0x01000000 },
>        */
> -    [VIRT_PCIE] =       { 0x10000000, 0x30000000 },
> -    [VIRT_MEM] =        { 0x40000000, 30ULL * 1024 * 1024 * 1024 },
> +    [VIRT_PCIE] =           { 0x10000000, 0x30000000 },
> +    [VIRT_MEM] =            { 0x40000000, 30ULL * 1024 * 1024 * 1024 },
>   };
>
>   static const int a15irqmap[] = {
>

Could we reserve more blanks in case of long name in the future? Then we 
won't deal the indentation again I guess.

-- 
Shannon

WARNING: multiple messages have this Message-ID (diff)
From: Shannon Zhao <shannon.zhao@linaro.org>
To: Eric Auger <eric.auger@linaro.org>,
	eric.auger@st.com, qemu-devel@nongnu.org,
	peter.maydell@linaro.org
Cc: patches@linaro.org, agraf@suse.de, alex.williamson@redhat.com,
	pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu,
	christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [RESEND PATCH v12 4/4] hw/arm/virt: change indentation in a15memmap
Date: Wed, 27 May 2015 22:05:50 +0800	[thread overview]
Message-ID: <5565CF3E.7040100@linaro.org> (raw)
In-Reply-To: <1432716470-2096-5-git-send-email-eric.auger@linaro.org>



On 2015年05月27日 16:47, Eric Auger wrote:
> Re-indent in a15memmap after VIRT_PLATFORM_BUS introduction
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
>
> v11 -> v12:
> - Add Alex R-b
> ---
>   hw/arm/virt.c | 26 +++++++++++++-------------
>   1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 199d031..6c1ec58 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -128,26 +128,26 @@ typedef struct {
>    */
>   static const MemMapEntry a15memmap[] = {
>       /* Space up to 0x8000000 is reserved for a boot ROM */
> -    [VIRT_FLASH] =      {          0, 0x08000000 },
> -    [VIRT_CPUPERIPHS] = { 0x08000000, 0x00020000 },
> +    [VIRT_FLASH] =          {          0, 0x08000000 },
> +    [VIRT_CPUPERIPHS] =     { 0x08000000, 0x00020000 },
>       /* GIC distributor and CPU interfaces sit inside the CPU peripheral space */
> -    [VIRT_GIC_DIST] =   { 0x08000000, 0x00010000 },
> -    [VIRT_GIC_CPU] =    { 0x08010000, 0x00010000 },
> -    [VIRT_UART] =       { 0x09000000, 0x00001000 },
> -    [VIRT_RTC] =        { 0x09010000, 0x00001000 },
> -    [VIRT_FW_CFG] =     { 0x09020000, 0x0000000a },
> -    [VIRT_MMIO] =       { 0x0a000000, 0x00000200 },
> +    [VIRT_GIC_DIST] =       { 0x08000000, 0x00010000 },
> +    [VIRT_GIC_CPU] =        { 0x08010000, 0x00010000 },
> +    [VIRT_UART] =           { 0x09000000, 0x00001000 },
> +    [VIRT_RTC] =            { 0x09010000, 0x00001000 },
> +    [VIRT_FW_CFG] =         { 0x09020000, 0x0000000a },
> +    [VIRT_MMIO] =           { 0x0a000000, 0x00000200 },
>       /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size */
>       [VIRT_PLATFORM_BUS] =   { 0x0c000000, 0x02000000 },
>       /*
>        * PCIE verbose map:
>        *
> -     * MMIO window      { 0x10000000, 0x2eff0000 },
> -     * PIO window       { 0x3eff0000, 0x00010000 },
> -     * ECAM             { 0x3f000000, 0x01000000 },
> +     * MMIO window          { 0x10000000, 0x2eff0000 },
> +     * PIO window           { 0x3eff0000, 0x00010000 },
> +     * ECAM                 { 0x3f000000, 0x01000000 },
>        */
> -    [VIRT_PCIE] =       { 0x10000000, 0x30000000 },
> -    [VIRT_MEM] =        { 0x40000000, 30ULL * 1024 * 1024 * 1024 },
> +    [VIRT_PCIE] =           { 0x10000000, 0x30000000 },
> +    [VIRT_MEM] =            { 0x40000000, 30ULL * 1024 * 1024 * 1024 },
>   };
>
>   static const int a15irqmap[] = {
>

Could we reserve more blanks in case of long name in the future? Then we 
won't deal the indentation again I guess.

-- 
Shannon

  reply	other threads:[~2015-05-27 14:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27  8:47 [RESEND PATCH v12 0/4] machvirt dynamic sysbus device instantiation Eric Auger
2015-05-27  8:47 ` [Qemu-devel] " Eric Auger
2015-05-27  8:47 ` [RESEND PATCH v12 1/4] hw/arm/sysbus-fdt: helpers for platform bus nodes addition Eric Auger
2015-05-27  8:47   ` [Qemu-devel] " Eric Auger
2015-05-27  8:47 ` [RESEND PATCH v12 2/4] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier Eric Auger
2015-05-27  8:47   ` [Qemu-devel] " Eric Auger
2015-05-27  8:47 ` [RESEND PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support Eric Auger
2015-05-27  8:47   ` [Qemu-devel] " Eric Auger
2015-05-27  8:47 ` [RESEND PATCH v12 4/4] hw/arm/virt: change indentation in a15memmap Eric Auger
2015-05-27  8:47   ` [Qemu-devel] " Eric Auger
2015-05-27 14:05   ` Shannon Zhao [this message]
2015-05-27 14:05     ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5565CF3E.7040100@linaro.org \
    --to=shannon.zhao@linaro.org \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@linaro.org \
    --cc=eric.auger@st.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.