All of lore.kernel.org
 help / color / mirror / Atom feed
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 0/4] arm64: add livepatch support
Date: Thu, 28 May 2015 18:58:22 +0900	[thread overview]
Message-ID: <5566E6BE.9060903@linaro.org> (raw)
In-Reply-To: <20150528085807.GA31001@arm.com>

On 05/28/2015 05:58 PM, Will Deacon wrote:
> On Thu, May 28, 2015 at 07:08:42AM +0100, Li Bin wrote:
>> On 2015/4/24 17:27, Jiri Kosina wrote:
>>> On Fri, 24 Apr 2015, AKASHI Takahiro wrote:
>>>
>>>> This patchset enables livepatch support on arm64.
>>>>
>>>> Livepatch was merged in v4.0, and allows replacying a function dynamically
>>>> based on ftrace framework, but it also requires -mfentry option of gcc.
>>>> Currently arm64 gcc doesn't support it, but by adding a helper function to
>>>> ftrace, we will be able to support livepatch on arch's which don't support
>>>> this option.
>>>>
>>>> I submit this patchset as RFC since I'm not quite sure that I'm doing
>>>> in the right way, or we should definitely support -fentry instead.
>>>
>>> I don't have arm64 cross-compiler handy, could you please copy/paste how
>>> does function prologue, generated by gcc -pg on arm64 look like?
>>>
>>
>> The function prologue on arm64 with gcc -pg look like as following:
>> func:
>>          stp     x29, x30, [sp, -48]!
>>          add     x29, sp, 0
>>          mov     x1, x30
>>          str     w0, [x29,28]
>>          mov     x0, x1
>>          bl      _mcount
>
> Just for the avoidance of confusion, this looks like a function with
> a live parameter in x0, which explains the str to the stack and the
> juggling of x30 into x0. I don't think there's necessarily a golden
> template for the prologue code.

We just started the discussion about gcc, -mfentry vs. a more generic option
that I mentioned in:
   http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/346632.html
on gcc's devel ML.

-Takahiro AKASHI

> Will
>

WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Will Deacon <will.deacon@arm.com>, Li Bin <huawei.libin@huawei.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"sjenning@redhat.com" <sjenning@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"vojtech@suse.cz" <vojtech@suse.cz>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
	"masami.hiramatsu.pt@hitachi.com"
	<masami.hiramatsu.pt@hitachi.com>,
	"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC 0/4] arm64: add livepatch support
Date: Thu, 28 May 2015 18:58:22 +0900	[thread overview]
Message-ID: <5566E6BE.9060903@linaro.org> (raw)
In-Reply-To: <20150528085807.GA31001@arm.com>

On 05/28/2015 05:58 PM, Will Deacon wrote:
> On Thu, May 28, 2015 at 07:08:42AM +0100, Li Bin wrote:
>> On 2015/4/24 17:27, Jiri Kosina wrote:
>>> On Fri, 24 Apr 2015, AKASHI Takahiro wrote:
>>>
>>>> This patchset enables livepatch support on arm64.
>>>>
>>>> Livepatch was merged in v4.0, and allows replacying a function dynamically
>>>> based on ftrace framework, but it also requires -mfentry option of gcc.
>>>> Currently arm64 gcc doesn't support it, but by adding a helper function to
>>>> ftrace, we will be able to support livepatch on arch's which don't support
>>>> this option.
>>>>
>>>> I submit this patchset as RFC since I'm not quite sure that I'm doing
>>>> in the right way, or we should definitely support -fentry instead.
>>>
>>> I don't have arm64 cross-compiler handy, could you please copy/paste how
>>> does function prologue, generated by gcc -pg on arm64 look like?
>>>
>>
>> The function prologue on arm64 with gcc -pg look like as following:
>> func:
>>          stp     x29, x30, [sp, -48]!
>>          add     x29, sp, 0
>>          mov     x1, x30
>>          str     w0, [x29,28]
>>          mov     x0, x1
>>          bl      _mcount
>
> Just for the avoidance of confusion, this looks like a function with
> a live parameter in x0, which explains the str to the stack and the
> juggling of x30 into x0. I don't think there's necessarily a golden
> template for the prologue code.

We just started the discussion about gcc, -mfentry vs. a more generic option
that I mentioned in:
   http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/346632.html
on gcc's devel ML.

-Takahiro AKASHI

> Will
>

  reply	other threads:[~2015-05-28  9:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24  2:44 [RFC 0/4] arm64: add livepatch support AKASHI Takahiro
2015-04-24  2:44 ` AKASHI Takahiro
2015-04-24  2:44 ` [RFC 1/4] ftrace: add a helper function for livepatch AKASHI Takahiro
2015-04-24  2:44   ` AKASHI Takahiro
2015-04-24  2:44 ` [RFC 2/4] livepatch: adjust a patched function's address AKASHI Takahiro
2015-04-24  2:44   ` AKASHI Takahiro
2015-04-24  2:44 ` [RFC 3/4] arm64: ftrace: add DYNAMIC_TRACE_WITH_REGS version AKASHI Takahiro
2015-04-24  2:44   ` AKASHI Takahiro
2015-04-24  2:44 ` [RFC 4/4] arm64: add livepatch support AKASHI Takahiro
2015-04-24  2:44   ` AKASHI Takahiro
2015-04-24  2:58 ` [RFC 0/4] " Steven Rostedt
2015-04-24  2:58   ` Steven Rostedt
2015-04-24  3:24 ` Li Bin
2015-04-24  3:24   ` Li Bin
2015-04-24  6:05   ` Masami Hiramatsu
2015-04-24  6:05     ` Masami Hiramatsu
2015-04-24  8:04     ` AKASHI Takahiro
2015-04-24  8:04       ` AKASHI Takahiro
2015-05-28  5:40     ` Li Bin
2015-05-28  5:40       ` Li Bin
2015-04-24  9:27 ` Jiri Kosina
2015-04-24  9:27   ` Jiri Kosina
2015-05-27  6:09   ` AKASHI Takahiro
2015-05-27  6:09     ` AKASHI Takahiro
2015-05-27  6:15     ` Jiri Kosina
2015-05-27  6:15       ` Jiri Kosina
2015-05-27  9:29     ` Masami Hiramatsu
2015-05-27  9:29       ` Masami Hiramatsu
2015-05-28  6:06   ` Li Bin
2015-05-28  6:08   ` Li Bin
2015-05-28  6:08     ` Li Bin
2015-05-28  8:58     ` Will Deacon
2015-05-28  8:58       ` Will Deacon
2015-05-28  9:58       ` AKASHI Takahiro [this message]
2015-05-28  9:58         ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5566E6BE.9060903@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.